[25.1] Fix dataset collection tag duplication when copying a history#21984
Merged
jmchilton merged 3 commits intogalaxyproject:release_25.1from Mar 11, 2026
Merged
Conversation
github-actions
Bot
added
area/testing
area/database
HistoryDatasetCollectionAssociation.copy() was internally calling copy_tags_from(), but both callers (History.copy() and DatasetCollectionManager.copy()) also called copy_tags_from() on the returned HDCA, resulting in every tag being duplicated. Move the tag-copying responsibility entirely into HDCA.copy() via a new target_user parameter (falling back to source history user), and remove the redundant copy_tags_from() calls from both callers. This is safer than the reverse approach since any future caller of HDCA.copy() will get correct tag copying automatically. Fixes galaxyproject#21872
mvdbeek
force-pushed
the
fix-redundant-tag-copy
branch
from
db43119 to
8f4577e
Compare
`__datasets_for_update` can return an empty list when the given ID doesn't match an HDA in the history, causing an unhandled IndexError.
The test was using the legacy untyped endpoint which defaults to dataset type, causing a 500 error when updating a collection's tags.
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
|
This PR was merged without a "kind/" label, please correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HistoryDatasetCollectionAssociation.copy() was internally calling copy_tags_from(), but both callers (History.copy() and DatasetCollectionManager.copy()) also called copy_tags_from() on the returned HDCA, resulting in every tag being duplicated.
Move the tag-copying responsibility entirely into HDCA.copy() via a new target_user parameter (falling back to source history user), and remove the redundant copy_tags_from() calls from both callers. This is safer than the reverse approach since any future caller of HDCA.copy() will get correct tag copying automatically.
Fixes #21872
How to test the changes?
(Select all options that apply)
License