Skip to content

[26.0] Add optional dataset collection mode to harmonize tool#22236

Merged
mvdbeek merged 2 commits intogalaxyproject:release_26.0from
mvdbeek:harmonize-optional-collection-mode
Mar 31, 2026
Merged

[26.0] Add optional dataset collection mode to harmonize tool#22236
mvdbeek merged 2 commits intogalaxyproject:release_26.0from
mvdbeek:harmonize-optional-collection-mode

Conversation

@mvdbeek
Copy link
Copy Markdown
Member

@mvdbeek mvdbeek commented Mar 23, 2026

When input2 is not provided, the tool produces:

  • output1: a copy of input1 (all elements preserved)
  • output2: same structure/identifiers as input1 but with expression.json null datasets

This enables workflows to use the harmonize tool with optional inputs, producing null-filled collections that can be filtered downstream with the Filter Null tool.

Bumps tool version to 1.1.0 and preserves 1.0.0 XML as backup. Closes #22080

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias
Copy link
Copy Markdown
Contributor

What is the policy regarding tools? Can this be included in 26.0?

@github-actions github-actions Bot added this to the 26.1 milestone Mar 23, 2026
@github-actions github-actions Bot changed the title Add optional dataset collection mode to harmonize tool [26.0] Add optional dataset collection mode to harmonize tool Mar 23, 2026
@mvdbeek mvdbeek force-pushed the harmonize-optional-collection-mode branch 2 times, most recently from 881cbe4 to a924a77 Compare March 23, 2026 21:36
mvdbeek added 2 commits March 31, 2026 15:08
When input2 is not provided, the tool produces:
- output1: a copy of input1 (all elements preserved)
- output2: same structure/identifiers as input1 but with
  expression.json null datasets

This enables workflows to use the harmonize tool with optional
inputs, producing null-filled collections that can be filtered
downstream with the Filter Null tool.

Bumps tool version to 1.1.0 and preserves 1.0.0 XML as backup.
Closes galaxyproject#22080
Override check_inputs_ready to skip the input2 key when the optional
collection is not provided, before delegating to the base class which
rightfully assumes all collection inputs are present.
@mvdbeek mvdbeek force-pushed the harmonize-optional-collection-mode branch from a924a77 to 7f3dce9 Compare March 31, 2026 13:08
@ahmedhamidawan ahmedhamidawan modified the milestones: 26.1, 26.0 Mar 31, 2026
@mvdbeek mvdbeek merged commit ffe50ea into galaxyproject:release_26.0 Mar 31, 2026
53 of 56 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants