Skip to content

Enable rules recently enabled in the GitHub monolith #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

sampart
Copy link
Contributor

@sampart sampart commented Mar 29, 2023

We've recently enabled some more cops in GitHub's Rails monolith, picking those which relate to our existing Ruby styleguide.

This PR upstreams those enablements into this gem. Where I found that a cop's autofixer mangled ERB files, I've included an exclusion for those.

@sampart sampart requested a review from a team as a code owner March 29, 2023 11:12
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sampart sampart merged commit 1f06af9 into main Mar 29, 2023
@sampart sampart deleted the enable-rules-enabled-in-github-monolith branch March 29, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants