Skip to content

Enable rules recently enabled in the GitHub monolith #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Enable rules recently enabled in the GitHub monolith #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,10 @@ Layout/SpaceAroundMethodCallOperator:
Enabled: false

Layout/SpaceAroundOperators:
Enabled: false
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-operators
Exclude:
- "**/*.erb"

Layout/SpaceBeforeBlockBraces:
Enabled: true
Expand Down Expand Up @@ -997,9 +1000,8 @@ Style/AccessorGrouping:
Style/Alias:
Enabled: false

# TODO: Enable this since it's in the styleguide.
Style/AndOr:
Enabled: false
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#no-and-or-or

Style/ArgumentsForwarding:
Expand Down Expand Up @@ -1057,7 +1059,8 @@ Style/ClassMethods:
Enabled: true

Style/ClassMethodsDefinitions:
Enabled: false
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#classes

Style/ClassVars:
Enabled: false
Expand Down Expand Up @@ -1373,7 +1376,10 @@ Style/NestedParenthesizedCalls:
Enabled: false

Style/NestedTernaryOperator:
Enabled: false
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#one-expression-per-branch
Exclude:
- "**/*.erb"

Style/Next:
Enabled: false
Expand Down Expand Up @@ -1424,7 +1430,10 @@ Style/OptionalBooleanParameter:
Enabled: false

Style/OrAssignment:
Enabled: false
Enabled: true
StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#memoize-away
Exclude:
- "**/*.erb"

Style/ParallelAssignment:
Enabled: false
Expand Down