Skip to content

feat: update base image to buildpack-deps:22.04-curl #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

andreafalzetti
Copy link
Contributor

Description

Updates the Dockerfile base image for this repo to buildpack-deps:22.04-curl

Related Issue(s)

Fixes gitpod-io/openvscode-server#377

Release Notes

NONE

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this change does not require any changes on https://github.com/gitpod-io/vscode-linux-build-agent.

Thanks @andreafalzetti, LGTM ✅.

@andreafalzetti
Copy link
Contributor Author

I'm assuming this change does not require any changes on https://github.com/gitpod-io/vscode-linux-build-agent.

Thanks @andreafalzetti, LGTM ✅.

I am not sure about https://github.com/gitpod-io/vscode-linux-build-agent. @jeanp413, do you know?


On the other hand, this docker build fails in Gitpod, when it runs apt-get update:

Reading package lists...
E: Problem executing scripts APT::Update::Post-Invoke 'rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true'
E: Sub-process returned an error code

It builds correctly for v21.04. We're testing if the GHA manages to build successfully: https://github.com/gitpod-io/openvscode-releases/actions/runs/2637752687

We might need to update the docker version in Gitpod's workspaces to build successfully, at least that's what I was able to find out with a bit of research on that error.

@andreafalzetti andreafalzetti merged commit b055031 into main Jul 8, 2022
@andreafalzetti andreafalzetti deleted the afalz/update-base-image branch July 8, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pls. consider Dockerfile base image transition Ubuntu 20.04 to 22.04
2 participants