Pls. consider Dockerfile base image transition Ubuntu 20.04 to 22.04

[wirepatch]

Current Docker image https://github.com/gitpod-io/openvscode-releases is based on Ubuntu 20.04 shipping a Maven version being incompatible with Openjdk-17 (and others). This makes it difficult for Java folks to extend your image.

[jeanp413]

Thanks for bringing this up @wirepatch.
@filiptronicek what do you think? I'd say let's update the base image to ubuntu 22.04, if users ask for 20.04 then we can look into adding more tags, something like 1.69.0-focal and 1.69.0-jammy

[filiptronicek]

@jeanp413 I think we should try it out and if everything builds correctly, I'll try testing it on my machine and if that is all good as well, we can merge the changes. I can take this.

I'm curious though @wirepatch about the incompatibility issue here: I'm not very familiar with Java, but I was able to install OpenJDK 17 with SDKMAN! just a couple of days ago.

[wirepatch]

@jeanp413 Thx for your swift reply. Hope your tests don't reveal any version related incompatibility.

@filiptronicek: It's a Ubuntu packaging issue being described i.e. at »How to install OpenJDK 17 on Ubuntu«. The author resolves the issue by manually installing a more recent Maven executable (A route I had had to follow as well).

Starting from (your) pristine buildpack-deps:20.04-curl image:

[root@martin-pc ~]# docker -D run  -d --name buildpack-deps.20.04-curl -it --init  buildpack-deps:20.04-curl
3985f61621b27b95059acd517a7a8ac61314759e6f4f597740076c27c4ccdf93
[root@martin-pc-dachboden ~]#  docker exec -u 0 -it buildpack-deps.20.04-curl bash
root@4f484a5a20a9:/# apt-get update && apt-get -y install openjdk-17-jdk
   ... omitted for brevity
done.

root@26969198847d:/# javac -version
javac 17.0.3

root@26969198847d:~# apt-get -y install maven
   ... omitted for brevity

root@26969198847d:~# mvn -version
Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 17.0.3, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: ANSI_X3.4-1968
OS name: "linux", version: "5.18.9-200.fc36.x86_64", arch: "amd64", family: "unix"

So far everything seems to work well. But deriving a new project from a Maven archetype fails:

root@26969198847d:/# mvn --batch-mode -e archetype:generate -DgroupId=my.test -DartifactId=quickstart -Dversion=1.0 -DarchetypeGroupId=org.apache.maven.archetypes -DarchetypeArtifactId=maven-archetype-quickstart -DarchetypeVersion=1.4
[ERROR] Error executing Maven.
com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalStateException: Unable to load cache item
    at com.google.common.cache.LocalCache$Segment.get (LocalCache.java:2205)
    at com.google.common.cache.LocalCache.get (LocalCache.java:3951)
    at com.google.common.cache.LocalCache.getOrLoad (LocalCache.java:3955)
   ... longer stack trace omitted for brevity

And working on an existing Maven project fails as well:

root@26969198847d:~# cd helloTemplate/
root@26969198847d:~/helloTemplate# ls
pom.xml  src
root@26969198847d:~/helloTemplate# mvn compile
[ERROR] Error executing Maven.
[ERROR] java.lang.IllegalStateException: Unable to load cache item
[ERROR] Caused by: Unable to load cache item
[ERROR] Caused by: Could not initialize class com.google.inject.internal.cglib.core.$MethodWrapper

As you can see this is the exact outcome as being described in the initial link's contribution.

[wirepatch]

BTW: Cheers for your excellent work. So far I'm just testing your beast but it really looks promising!

[filiptronicek]

Thanks @wirepatch for the kind words and the explanation 🧡!

and just to be clear here: are you reffering to the base image on https://gitpod.io or are you talking about OpenVSCode Server?

[wirepatch]

I do refer to your Docker image https://hub.docker.com/r/gitpod/openvscode-server. By virtue of https://github.com/gitpod-io/openvscode-releases/blob/main/Dockerfile this image starts from the Ubuntu 20.04 base image buildpack-deps:20.04-curl (my understanding so far at least). Your idea adding more tags sounds perfect.

BTW: The documentation at https://hub.docker.com/r/gitpod/openvscode-server uses -v "$(pwd):/home/workspace:cached". Searching for the cached (sub)option a remark claimed this one having been obsoleted. It does not appear in the current reference documentation at https://docs.docker.com/engine/reference/commandline/run/#mount-volumes-from-container---volumes-from .

[filiptronicek]

BTW: The documentation at hub.docker.com/r/gitpod/openvscode-server uses -v "$(pwd):/home/workspace:cached". Searching for the cached (sub)option a remark claimed this one having been obsoleted. It does not appear in the current reference documentation at docs.docker.com/engine/reference/commandline/run/#mount-volumes-from-container---volumes-from .

Thanks for noting, @wirepatch, I will revisit the docs we have here.