Move ingester_traces_created_total#2884
Merged
joe-elliott merged 2 commits intografana:mainfrom Sep 1, 2023
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
electron0zero,
ie-pham,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
galalen
pushed a commit
to galalen/tempo
that referenced
this pull request
Sep 3, 2023
* move metric Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Moves the location we are calculating
tempo_ingester_traces_created_totalto the point at which a trace is appended to the wal block. This will allow for better alignment withtempodb_warnings_total{reason="disconnected_trace_flushed_to_wal"}which improves the accuracy of the formulas recommended here:#2790
Preferring this to adding a new multitenant metric. This change doesn't really lower the value of
tempo_ingester_traces_created_totalit just subtly changes it's meaning. Given that it still broadly metrics traces created total this feels fine to me, but willing to be disagreed with.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]