Skip to content

Move ingester_traces_created_total #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joe-elliott merged 2 commits into from
Sep 1, 2023
Merged

Move ingester_traces_created_total #2884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6534f4f
move metric
joe-elliott Sep 1, 2023
b2ca5dc
changelog
joe-elliott Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* [FEATURE] Add cli command to print out summary of large traces [#2775](https://github.com/grafana/tempo/pull/2775) (@ie-pham)
* [CHANGE] Update Go to 1.21 [#2486](https://github.com/grafana/tempo/pull/2829) (@zalegrala)
* [CHANGE] Make metrics-generator ingestion slack per tenant [#2589](https://github.com/grafana/tempo/pull/2589) (@ie-pham)
* [CHANGE] Moved the tempo_ingester_traces_created_total metric to be incremented when a trace is cut to the wal [#2884](https://github.com/grafana/tempo/pull/2884) (@joe-elliott)
* [ENHANCEMENT] Add block indexes to vParquet2 and vParquet3 to improve trace by ID lookup [#2697](https://github.com/grafana/tempo/pull/2697) (@mdisibio)
* [ENHANCEMENT] Assert ingestion rate limits as early as possible [#2640](https://github.com/grafana/tempo/pull/2703) (@mghildiy)
* [ENHANCEMENT] Add several metrics-generator fields to user-configurable overrides [#2711](https://github.com/grafana/tempo/pull/2711) (@kvrhdn)
Expand Down
2 changes: 1 addition & 1 deletion modules/ingester/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,6 @@ func (i *instance) getOrCreateTrace(traceID []byte, fp uint32, maxBytes int) *li

trace = newTrace(traceID, maxBytes)
i.traces[fp] = trace
i.tracesCreatedTotal.Inc()
i.traceCount.Inc()

return trace
Expand Down Expand Up @@ -536,6 +535,7 @@ func (i *instance) writeTraceToHeadBlock(id common.ID, b []byte, start, end uint
i.headBlockMtx.Lock()
defer i.headBlockMtx.Unlock()

i.tracesCreatedTotal.Inc()
err := i.headBlock.Append(id, b, start, end)
if err != nil {
return err
Expand Down