Golangci deprecations and update using tools pattern#3610
Merged
zalegrala merged 4 commits intografana:mainfrom May 8, 2024
Merged
Golangci deprecations and update using tools pattern#3610zalegrala merged 4 commits intografana:mainfrom
zalegrala merged 4 commits intografana:mainfrom
Conversation
zalegrala
force-pushed
the
golangciDeprecationsAndUpdate
branch
from
2e54b32 to
14379fb
Compare
zalegrala
changed the title
Contributor
Author
|
I have a follow up commit ready to update CI. Once the new image has been published, then we can use |
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
joe-elliott
approved these changes
May 7, 2024
Collaborator
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
Love how clean this addition is. Nice work!
zalegrala
force-pushed
the
golangciDeprecationsAndUpdate
branch
from
e38c313 to
12d0856
Compare
4 tasks
zalegrala
added a commit
to zalegrala/tempo
that referenced
this pull request
May 14, 2024
* Breadcrumbs for golangci * Include golangci in tools * Use tools image for lint make target * Update changelog (cherry picked from commit b76ab98)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we move golangci to the tools pattern to execute in docker. Users can now run
make lintwith the same version of golangci.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]