Use tools image for lint in CI and allow passing base ref#3660
Merged
zalegrala merged 2 commits intografana:mainfrom May 10, 2024
Merged
Use tools image for lint in CI and allow passing base ref#3660zalegrala merged 2 commits intografana:mainfrom
zalegrala merged 2 commits intografana:mainfrom
Conversation
zalegrala
force-pushed
the
golangciDeprecationsAndUpdateCI
branch
from
e9c6808 to
d17871e
Compare
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
electron0zero
approved these changes
May 9, 2024
zalegrala
added a commit
to zalegrala/tempo
that referenced
this pull request
May 14, 2024
* Use tools image for lint in CI and allow passing base ref * Add fetch detpth for main diff (cherry picked from commit 496b450)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
As a follow up to #3610, here we update CI to use the
make linttarget. This will mean the local and CI version of golangci-lint will match.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]