doc: correct traceQL metrics documentation#4252
Merged
knylander-grafana merged 2 commits intografana:mainfrom Nov 4, 2024
Merged
doc: correct traceQL metrics documentation#4252knylander-grafana merged 2 commits intografana:mainfrom
knylander-grafana merged 2 commits intografana:mainfrom
Conversation
javiermolinar
added
type/docs
javiermolinar
requested review from
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer and
zalegrala
as code owners
Contributor
|
This PR must be merged before a backport PR will be created. |
1 similar comment
Contributor
|
This PR must be merged before a backport PR will be created. |
| ### Functions | ||
|
|
||
| TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`. | ||
| TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`,`min_over_tim`,`max_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`. |
Contributor
There was a problem hiding this comment.
Adds missing spaces between min and max over time.
Suggested change
| TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`,`min_over_tim`,`max_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`. | |
| TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`, `min_over_tim`, `max_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`. |
knylander-grafana
approved these changes
Nov 4, 2024
Contributor
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for updating the docs! I've added two suggestions or missing spaces between min and max time.
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> (cherry picked from commit fc05aec)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It corrects some typos in the documentation relative to TraceQL Metrics
Checklist