Handle invalid TraceQL query filter in tag values v2 disk cache#4392
Merged
electron0zero merged 2 commits intografana:mainfrom Nov 27, 2024
Merged
Handle invalid TraceQL query filter in tag values v2 disk cache#4392electron0zero merged 2 commits intografana:mainfrom
electron0zero merged 2 commits intografana:mainfrom
Conversation
electron0zero
requested review from
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
electron0zero
changed the title
joe-elliott
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
In case of a bad TraceQL query, disk cache for search tag values v2 endpoints would fail to set and get cache.
bug was that we returned
""as cache key when we failed to parse the TraceQL filter query.Invalid filter TraceQL query is treated as empty query in the tag values v2 endpoint so follow the same semantics for disk cache.
I also added some tests for search tag values v2 to make sure we test for the invalid TraceQL query behaviour.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]