[DOC] Remove tempo_discarded_spans_total from doc#4688
Closed
knylander-grafana wants to merge 1 commit intografana:mainfrom
knylander-grafana:ts-558-remove-internal-error-reason-doc
Closed
[DOC] Remove tempo_discarded_spans_total from doc#4688knylander-grafana wants to merge 1 commit intografana:mainfrom knylander-grafana:ts-558-remove-internal-error-reason-doc
knylander-grafana wants to merge 1 commit intografana:mainfrom
knylander-grafana:ts-558-remove-internal-error-reason-doc
Conversation
knylander-grafana
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
| msg="pusher failed to consume trace data" err="rpc error: code = ResourceExhausted desc = RATE_LIMITED: ingestion rate limit (15000000 bytes) exceeded while adding 10 bytes" | ||
| ``` | ||
|
|
||
| You'll also see the following metric incremented. The `reason` label on this metric will contain information about the refused reason. |
Contributor
Author
There was a problem hiding this comment.
Should we replace this with anything?
Collaborator
There was a problem hiding this comment.
tempo_discarded_spans_total still exists. we just remove the "InternalError" reason
Contributor
Author
There was a problem hiding this comment.
Oh! My bad for misunderstanding. I'll update this doc then. This was the only place in the Tempo docs that we mentioned tempo_discarded_spans_total.
Contributor
Author
There was a problem hiding this comment.
This makes me wonder where (and if) we should document the behavior for the change or only have the change from this PR listed in release notes in the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removes tempo_discoarded_spans_total from doc.
Reference: #4554
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/tempo-squad/issues/558
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]