Skip to content

[DOC] Remove tempo_discarded_spans_total from doc #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
knylander-grafana wants to merge 1 commit into from
Closed

[DOC] Remove tempo_discarded_spans_total from doc #4688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions docs/sources/tempo/troubleshooting/send-traces/max-trace-limit-reached.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,7 @@ msg="pusher failed to consume trace data" err="rpc error: code = FailedPrecondit
msg="pusher failed to consume trace data" err="rpc error: code = ResourceExhausted desc = RATE_LIMITED: ingestion rate limit (15000000 bytes) exceeded while adding 10 bytes"
```

You'll also see the following metric incremented. The `reason` label on this metric will contain information about the refused reason.
Copy link
Copy Markdown
Contributor Author

@knylander-grafana knylander-grafana Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace this with anything?

Copy link
Copy Markdown
Collaborator

@joe-elliott joe-elliott Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tempo_discarded_spans_total still exists. we just remove the "InternalError" reason

Copy link
Copy Markdown
Contributor Author

@knylander-grafana knylander-grafana Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! My bad for misunderstanding. I'll update this doc then. This was the only place in the Tempo docs that we mentioned tempo_discarded_spans_total.

Copy link
Copy Markdown
Contributor Author

@knylander-grafana knylander-grafana Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder where (and if) we should document the behavior for the change or only have the change from this PR listed in release notes in the next release.


```
tempo_discarded_spans_total
```

In this case, use available configuration options to [increase limits](https://grafana.com/docs/tempo/<TEMPO_VERSION>/configuration/#ingestion-limits).
If indicated, you can use available configuration options to [increase limits](https://grafana.com/docs/tempo/<TEMPO_VERSION>/configuration/#ingestion-limits).

## Client resets connection

Expand Down