HHH-18837 Oracle epoch extraction doesn't work with dates #10296
Conversation
| }) | ||
| @RequiresDialect(OracleDialect.class) | ||
| @JiraKey("HHH-18837") | ||
| public class OracleDateTypeTest { |
There was a problem hiding this comment.
This is fine, but how about trying to use an existing test (and not restrict it to Oracle only)? For example, a new method similar to org.hibernate.orm.test.query.hql.FunctionTests#testExtractFunctionEpoch in that class (or others).
| new PatternRenderer( pattern ).render( sqlAppender, sqlAstArguments, walker ); | ||
| final Expression expression = (Expression) sqlAstArguments.get( 1 ); | ||
| final TemporalType temporalType; | ||
| if ( dialect instanceof OracleDialect && (temporalType = getSqlTemporalType( |
There was a problem hiding this comment.
This instanceof is not the best. We should rather have a custom OracleExtractFunction, that is registered in OracleDialect#initializeFunctionRegistry overriding the default implementation. That would also allow us to avoid having the new extractPattern with 2 parameters in Dialect, and keep this logic in oracle-specific implementation.
There was a problem hiding this comment.
Ah, thank you very much for that hint.
I was sure that you would not like the new method in Dialect.
I will let you know when the PR is ready for a new review.
This PR fixes an error when using
epochwith dates on Oracle.I added an overload of
extractPattern(which is overridden inOracleDialect) to handle differentTemporalType.This new method is only used in
ExtractFunctionin context ofOracleDialect.https://hibernate.atlassian.net/browse/HHH-18837
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.