Update MsgUpdateClient handlers to accept misbehaviour reports via its client_message field
#1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
- Coverage 66.71% 66.67% -0.04%
==========================================
Files 204 204
Lines 20447 20436 -11
==========================================
- Hits 13641 13626 -15
- Misses 6806 6810 +4 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Thank you @seanchen1991 for taking care of this.
-
There are a few tests still only use
MsgSubmitMibehavour. Since we're planning to deprecate this type, we are going to switch those over toMsgUpdateClientlater. right? -
Also, please add a unclog and update the PR’s title, then all set.
seanchen1991
changed the title
MsgSubmitMisbehaviour in favor of MsgUpddateClientMsgUpdateClient handlers to accept misbehaviour reports via its client_message field
…ent-update-misbehaviour
…cosmos/ibc-rs into sean/client-update-misbehaviour
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…its `client_message` field (#1075) * Check MsgUpdateClient::client_message by matching against type_url * Update ibc testkit mock * Remove leading underscores * Remove code comments * Clean up compilation issues from ibc testkit * Fix ambiguous import issue * Add passing tests * Add deprecation attribute to `MsgSubmitMisbehaviour` type * Remove deprecated attribute from MsgSubmitMisbehaviour * Remove std::dbg call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #835
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.