Skip to content

chore(rust/signed-doc): Cleanup Catalyst Signed Document Builder, make it type safe, add special test builder. #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: feat/new-cat-signed-doc
Choose a base branch
from

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Jun 20, 2025

Description

  • Split current Builder into the sequence of three builders MetadataBuilder, ContentBuilder, SignaturesBuilder. Which makes the building process type safe.
  • Added a new tests::Builder based on the safe builder, to be more flexible in tests.
  • Updated and cleanup tests

Related Issue

Part of #330

@Mr-Leshiy Mr-Leshiy changed the title chore(rust/signed-doc): Cleanup Catalyst Signed Document Builder, make it type safe chore(rust/signed-doc): Cleanup Catalyst Signed Document Builder, make it type safe, add special test builder. Jun 20, 2025
@Mr-Leshiy Mr-Leshiy self-assigned this Jun 20, 2025
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Jun 20, 2025
@Mr-Leshiy Mr-Leshiy requested review from bkioshn and apskhem June 20, 2025 13:47
@Mr-Leshiy Mr-Leshiy requested a review from no30bit June 20, 2025 13:47
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review June 20, 2025 13:47
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Jun 20, 2025
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Test Report | ${\color{lightgreen}Pass: 350/350}$ | ${\color{red}Fail: 0/350}$ |

@stevenj
Copy link
Collaborator

stevenj commented Jun 21, 2025

Whats the parent issue?

@Mr-Leshiy
Copy link
Contributor Author

Mr-Leshiy commented Jun 21, 2025

Whats the parent issue?

@stevenj didn't create a separate issue for it, its a part of the #330 updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants