Adds blueprint environment for Franka stacking mimic #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a jupyter notebook for generate_dataset.py * Move functions in generate_dataset to isaaclab_mimic/datagen/generation.py * Add utils.py for utility function for the notebook * Add dependency for ipywidgets * Add randomizable_params in EventTermCfg for franka stack_joint_pos_env_cfg
chengronglai
requested review from
jsmith-bdai,
kellyguo11,
Mayankm96 and
jtigue-bdai
as code owners
* Clearer description of randomizable parameters for users * Use FloatRangeSlider and FloatSlider to adjust value * Update scene with reset and stepping for better visual feedback
ashwinvkNV
approved these changes
Feb 28, 2025
kellyguo11
reviewed
Feb 28, 2025
|
looks like the docs are failing to build, might need to add ipywidgets to conf.py. will |
Mayankm96
reviewed
Mar 1, 2025
...sks/isaaclab_tasks/manager_based/manipulation/stack/config/franka/stack_joint_pos_env_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Mar 1, 2025
* Add proper type hints to all functions in datagen/utils.py and datagen/generation.py
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Fixes # (issue) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Peter Du <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
…randomization_selection_data_generation
…randomization_selection_data_generation
kellyguo11
approved these changes
Mar 6, 2025
kellyguo11
changed the title
…randomization_selection_data_generation
kellyguo11
reviewed
Mar 10, 2025
Signed-off-by: Kelly Guo <[email protected]>
kellyguo11
deleted the
chengrongl/randomization_selection_data_generation
branch
jtigue-bdai
pushed a commit
that referenced
this pull request
Apr 14, 2025
# Description This pull request refactors the core functionality of generate_dataset.py into separate helper modules. The goal is to make the associated Jupyter notebook leaner. * Move functions in generate_dataset to isaaclab_mimic/datagen/generation.py * Add utils.py for utility function for the notebook * Add dependency for ipywidgets ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [ x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Jean-Francois-Lafleche <[email protected]> Co-authored-by: Peter Du <[email protected]> Co-authored-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
ToxicNS
pushed a commit
to ToxicNS/IsaacLab
that referenced
this pull request
Apr 24, 2025
# Description This pull request refactors the core functionality of generate_dataset.py into separate helper modules. The goal is to make the associated Jupyter notebook leaner. * Move functions in generate_dataset to isaaclab_mimic/datagen/generation.py * Add utils.py for utility function for the notebook * Add dependency for ipywidgets ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [ x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Kelly Guo <[email protected]> Co-authored-by: Jean-Francois-Lafleche <[email protected]> Co-authored-by: Peter Du <[email protected]> Co-authored-by: Kelly Guo <[email protected]> Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the core functionality of generate_dataset.py into separate helper modules. The goal is to make the associated Jupyter notebook leaner.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there