Skip to content

Rename theme variables to match industry practice#3174

Merged
yurishkuro merged 4 commits intomainfrom
theming-01
Nov 28, 2025
Merged

Rename theme variables to match industry practice#3174
yurishkuro merged 4 commits intomainfrom
theming-01

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

@yurishkuro yurishkuro commented Nov 28, 2025

Which problem is this PR solving?

Description of the changes

  • Rename what minimum number of vars is used to follow semantic naming practice

How was this change tested?

  • added css linter to verify that vars are not missing

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 28, 2025 03:00
@yurishkuro yurishkuro requested review from mahadzaryab1 and removed request for a team November 28, 2025 03:00
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 28, 2025
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Theming 01 Rename theme varibales to match industry practice Nov 28, 2025
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.92%. Comparing base (b03affc) to head (d2c0d04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3174   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files         260      260           
  Lines        8162     8162           
  Branches     2122     2151   +29     
=======================================
  Hits         7993     7993           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro changed the title Rename theme varibales to match industry practice Rename theme variables to match industry practice Nov 28, 2025
@yurishkuro yurishkuro merged commit 55bb83a into main Nov 28, 2025
11 checks passed
@yurishkuro yurishkuro deleted the theming-01 branch January 1, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant