Skip to content

Rename theme variables to match industry practice #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 4 commits into from
Nov 28, 2025
Merged

Rename theme variables to match industry practice #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5c078a
Rename theme varibales to match industry practice
yurishkuro Nov 28, 2025
334c481
add-linter
yurishkuro Nov 28, 2025
87a4857
remove linter
yurishkuro Nov 28, 2025
d2c0d04
rm
yurishkuro Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/jaeger-ui/.stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"extends": "stylelint-config-recommended",
"plugins": ["stylelint-value-no-unknown-custom-properties"],
"rules": {
"csstools/value-no-unknown-custom-properties": [
true,
{
"importFrom": ["src/components/common/vars.css"]
}
],
"no-descending-specificity": null,
"font-family-no-missing-generic-family-keyword": null,
"property-no-deprecated": null,
"declaration-block-no-duplicate-properties": null,
"declaration-property-value-no-unknown": null,
"no-duplicate-selectors": null,
"shorthand-property-no-redundant-values": null,
"declaration-block-no-redundant-longhand-properties": null,
"declaration-property-value-keyword-no-deprecated": null
}
}
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/DeepDependencies/Header/HopsSelector/Selector.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ SPDX-License-Identifier: Apache-2.0
*/

.HopsSelector--Selector {
color: var(--tx-color-muted);
color: var(--text-muted);
margin: 0 0.5em;
padding: 0px 3px;
}
Expand Down
3 changes: 2 additions & 1 deletion packages/jaeger-ui/src/components/DeepDependencies/Header/LayoutSettings/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ SPDX-License-Identifier: Apache-2.0
.Ddg--LayoutSettings {
margin-right: 3em;
}

.Ddg--LayoutSettings--optionsTable > tbody > tr {
vertical-align: top;
}
Expand All @@ -29,7 +30,7 @@ SPDX-License-Identifier: Apache-2.0
}

.Ddg--LayoutSettings--optionNote {
color: var(--tx-color-title);
color: var(--text-primary);
}

.Ddg--LayoutSettings--optionDescription {
Expand Down
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/DeepDependencies/Header/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ SPDX-License-Identifier: Apache-2.0
}

.DdgHeader--uiFindInfo--hidden {
border-left: dashed var(--tx-color-muted) 1px;
border-left: dashed var(--text-muted) 1px;
margin-left: 0.3em;
padding-left: 0.3em;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/jaeger-ui/src/components/QualityMetrics/Header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ SPDX-License-Identifier: Apache-2.0
}

.QualityMetrics--Header--LookbackLabel {
color: var(--tx-color-muted);
color: var(--text-muted);
cursor: pointer;
font-size: 1.5em;
margin: 0 0.6em 0 0;
outline: 4px solid transparent;
}

.QualityMetrics--Header--LookbackSuffix {
color: var(--tx-color-muted);
color: var(--text-muted);
margin: 0 0 0 0.6em;
outline: 4px solid transparent;
}
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ SPDX-License-Identifier: Apache-2.0

.SearchResults--header {
border: 1px solid #e6e6e6;
color: var(--tx-color-title);
color: var(--text-primary);
margin-bottom: 1.25rem;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/TraceDiff/TraceDiffGraph/renderNode.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ SPDX-License-Identifier: Apache-2.0
}

.DiffNode.is-changed {
color: var(--tx-color-title);
color: var(--text-primary);
}

.DiffNode.is-more {
Expand Down
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/CohortTable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ SPDX-License-Identifier: Apache-2.0
*/

.CohortTable--traceName {
color: var(--tx-color-title);
color: var(--text-primary);
}

.CohortTable--needMoreMsg {
Expand Down
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageHeader.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ SPDX-License-Identifier: Apache-2.0

.TracePageHeader--titleLink {
align-items: center;
color: var(--tx-color-title);
color: var(--text-primary);
display: flex;
flex: 1;
}
Expand Down
6 changes: 3 additions & 3 deletions packages/jaeger-ui/src/components/common/FilteredList/ListItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ SPDX-License-Identifier: Apache-2.0
rgba(135, 232, 222, 0.2) 70%,
rgba(135, 232, 222, 0)
);
color: var(--tx-color-title);
color: var(--text-primary);
}

.FilteredList--ListItem.is-selected {
background: linear-gradient(to right, #87e8de, #87e8deaa 70%, #87e8de00);
color: var(--tx-color-title);
color: var(--text-primary);
}

.FilteredList--ListItem.is-striped.is-focused,
Expand All @@ -40,7 +40,7 @@ SPDX-License-Identifier: Apache-2.0
rgba(17, 153, 153, 0.2) 70%,
rgba(17, 153, 153, 0)
);
color: var(--tx-color-title);
color: var(--text-primary);
}

.FilteredList--ListItem mark {
Expand Down
10 changes: 5 additions & 5 deletions packages/jaeger-ui/src/components/common/NameSelector.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ SPDX-License-Identifier: Apache-2.0

.NameSelector {
border-bottom: 1px solid transparent;
color: var(--tx-color-muted);
color: var(--text-muted);
cursor: pointer;
font-size: 1.5em;
margin: 0 1.3em 0 0;
Expand All @@ -27,14 +27,14 @@ SPDX-License-Identifier: Apache-2.0
.NameSelector:hover {
background: #f4f4f4;
border-color: #ccc;
color: var(--tx-color-body);
color: var(--text-secondary);
outline-color: #f4f4f4;
}

.NameSelector.is-active {
background: #ddd;
border-color: #bbb;
color: var(--tx-color-body);
color: var(--text-secondary);
outline-color: #ddd;
}

Expand All @@ -44,7 +44,7 @@ SPDX-License-Identifier: Apache-2.0
}

.NameSelector--value {
color: var(--tx-color-title);
color: var(--text-primary);
}

.NameSelector--chevron {
Expand All @@ -58,7 +58,7 @@ SPDX-License-Identifier: Apache-2.0
}

.NameSelector--clearIcon:not(:hover) {
color: var(--tx-color-muted);
color: var(--text-muted);
}

.NameSelector--overlay .ant-popover-arrow {
Expand Down
6 changes: 1 addition & 5 deletions packages/jaeger-ui/src/components/common/utils.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ Copyright (c) 2017 Uber Technologies, Inc.
SPDX-License-Identifier: Apache-2.0
*/

:root {
--nav-height: 48px;
}

.u-width-100 {
width: 100%;
}
Expand All @@ -24,7 +20,7 @@ SPDX-License-Identifier: Apache-2.0
}

.u-tx-muted {
color: var(--tx-color-muted);
color: var(--text-muted);
}

.u-tx-inherit {
Expand Down
20 changes: 16 additions & 4 deletions packages/jaeger-ui/src/components/common/vars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,22 @@
/*
Copyright (c) 2018 Uber Technologies, Inc.
Copyright (c) 2025 Jaeger Authors
SPDX-License-Identifier: Apache-2.0
*/

/**
* Centralized CSS Variables for Theming
*
* This file contains all color and layout variables used throughout the application.
* New naming scheme follows semantic conventions for better maintainability.
*/

:root {
--tx-color-title: rgba(0, 0, 0, 0.85);
--tx-color-body: rgba(0, 0, 0, 0.65);
--tx-color-muted: #aaa;
/* ===== Text Colors ===== */
/* New token naming scheme */
--text-primary: rgba(0, 0, 0, 0.85);
--text-secondary: rgba(0, 0, 0, 0.65);
--text-muted: #aaa;

/* ===== Layout Variables ===== */
--nav-height: 48px;
}