[Jaeger-Agent] Use RawConn.Control to get fd instead of Fd()#4449
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom May 11, 2023
Merged
[Jaeger-Agent] Use RawConn.Control to get fd instead of Fd()#4449yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro merged 1 commit intojaegertracing:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4449 +/- ##
==========================================
- Coverage 97.07% 97.05% -0.03%
==========================================
Files 300 300
Lines 17728 17738 +10
==========================================
+ Hits 17210 17215 +5
- Misses 416 419 +3
- Partials 102 104 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
May 10, 2023
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
please make sure commits are signed
Signed-off-by: Chen Xu <chen.x@uber.com>
Contributor
Author
Signed |
yurishkuro
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #4448
Short description of the changes
Jaeger agent gets stuck when closing with SocketBufferSize set. This is because
Close()ofnet.UDPConnwill be blocked ifFd()is used to get the file descriptor.Use
RawConn.Controlinstead to get fd to set the socket buffer.Same issue was discussed here: golang/go#29277
The fix refers to here: brucespang/go-tcpinfo#3