Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions cmd/agent/app/agent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,36 @@ func TestStartStopRace(t *testing.T) {
t.Fatal("Expecting server exit log")
}

func TestStartStopWithSocketBufferSet(t *testing.T) {
resetDefaultPrometheusRegistry()
cfg := Builder{
Processors: []ProcessorConfiguration{
{
Model: jaegerModel,
Protocol: compactProtocol,
Workers: 1,
Server: ServerConfiguration{
HostPort: "127.0.0.1:0",
SocketBufferSize: 10,
},
},
},
}
mBldr := &metricsbuilder.Builder{HTTPRoute: "/metrics", Backend: "prometheus"}
metricsFactory, err := mBldr.CreateMetricsFactory("jaeger")
mFactory := fork.New("internal", metrics.NullFactory, metricsFactory)
require.NoError(t, err)
agent, err := cfg.CreateAgent(fakeCollectorProxy{}, zap.NewNop(), mFactory)
require.NoError(t, err)

if err := agent.Run(); err != nil {
t.Fatalf("error from agent.Run(): %s", err)
}

t.Log("stopping agent")
agent.Stop()
}

func resetDefaultPrometheusRegistry() {
// Create and assign a new Prometheus Registerer/Gatherer for each test
registry := prometheus.NewRegistry()
Expand Down
18 changes: 15 additions & 3 deletions cmd/agent/app/servers/thriftudp/socket_buffer.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,27 @@
package thriftudp

import (
"fmt"
"net"
"syscall"
)

func setSocketBuffer(conn *net.UDPConn, bufferSize int) error {
file, err := conn.File()
rawConn, err := conn.SyscallConn()
if err != nil {
return err
return fmt.Errorf("failed to get raw connection: %w", err)
}

return syscall.SetsockoptInt(int(file.Fd()), syscall.SOL_SOCKET, syscall.SO_RCVBUF, bufferSize)
var syscallErr error
controlErr := rawConn.Control(func(fd uintptr) {
syscallErr = syscall.SetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_RCVBUF, bufferSize)
})
if controlErr != nil {
return fmt.Errorf("rawconn control failed: %w", controlErr)
}
if syscallErr != nil {
return fmt.Errorf("syscall failed: %w", syscallErr)
}

return nil
}