make cassandra service_name_index inserts idempotent#587
Merged
yurishkuro merged 2 commits intojaegertracing:masterfrom Dec 6, 2017
Merged
make cassandra service_name_index inserts idempotent#587yurishkuro merged 2 commits intojaegertracing:masterfrom
yurishkuro merged 2 commits intojaegertracing:masterfrom
Conversation
kwojcik
requested review from
black-adder,
pavolloffay,
vprithvi and
yurishkuro
as code owners
Signed-off-by: Kevin Wojcik <kwojcik@uber.com>
black-adder
approved these changes
Dec 6, 2017
| @@ -200,7 +198,7 @@ func (s *SpanWriter) indexByDuration(span *dbmodel.Span, startTime time.Time) er | |||
| } | |||
|
|
|||
| func (s *SpanWriter) indexBySerice(traceID model.TraceID, span *dbmodel.Span) error { | |||
Contributor
There was a problem hiding this comment.
while you're here, do you mind doing s/indexBySerice/indexByService :D
|
Changes Unknown when pulling f9fa47b on kwojcik:idem into ** on jaegertracing:master**. |
|
Changes Unknown when pulling 87eba97 on kwojcik:idem into ** on jaegertracing:master**. |
|
Changes Unknown when pulling 87eba97 on kwojcik:idem into ** on jaegertracing:master**. |
yurishkuro
approved these changes
Dec 6, 2017
| func (s *SpanWriter) indexBySerice(traceID model.TraceID, span *dbmodel.Span) error { | ||
| bucketNo := atomic.AddUint32(&s.bucketCounter, 1) % defaultNumBuckets | ||
| func (s *SpanWriter) indexByService(traceID model.TraceID, span *dbmodel.Span) error { | ||
| bucketNo := span.SpanHash % defaultNumBuckets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the span hash as the source of variation for bucket choice instead of an atomic counter so that the inserts are idempotent.
Signed-off-by: Kevin Wojcik kwojcik@uber.com