Ensure Cassandra bucket number is not negative#599
Merged
yurishkuro merged 1 commit intomasterfrom Dec 17, 2017
Merged
Conversation
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
requested review from
black-adder,
pavolloffay and
vprithvi
as code owners
ghost
assigned
pavolloffay
approved these changes
Dec 17, 2017
Member
|
anyways I wanted to update my PR with this change |
Member
Author
|
ah ok, wasn't sure. I'll merge this since is't a very small change that evidently solves the spark job issue, but I am not sure about the other PR that changes the DB model. |
Member
|
it seems that storage tests are not sufficient. They were passing even though, query service could not get spans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span hash is used for cassandra buckets, but since it's signed it can produce negative numbers.
Related to #587, replaces #595
Resolves jaegertracing/spark-dependencies#23