Fix enforce-switch-style linting errors#7387
Conversation
|
Let me know if any changes are needed. I’ll be happy to adjust the PR as necessary. |
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
Please sign off the commit. Will probably need to add unit tests to maintain coverage.
| case -1: | ||
| // left < right, increase left one | ||
| l++ | ||
| default: |
There was a problem hiding this comment.
Doesn't make sense in this context. I'd rather move case 0 to default (and change the others to greater/less 0)
yurishkuro
added
the
changelog:refactoring
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7387 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 375 375
Lines 22878 22910 +32
==========================================
+ Hits 22070 22099 +29
- Misses 611 613 +2
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Head branch was pushed to by a user without write access
…dling Signed-off-by: Andrei-hub11 <andreirodrigues794@gmail.com>
Signed-off-by: Andrei-hub11 <andreirodrigues794@gmail.com>
Head branch was pushed to by a user without write access
|
Hi @yurishkuro Sorry for the multiple CI failures. I've now run golangci-lint locally and confirmed all issues are resolved. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
internal/storage/v2/elasticsearch/tracestore/to_dbmodel_test.go
Outdated
Show resolved
Hide resolved
2 participants
Added
defaultcases to switch statements across the codebase to comply with new linting rules.Changes
defaultcases to 15+ switch statementsnoctxerror by replacingnet.Listenwith(*net.ListenConfig).ListenAll changes preserve original functionality while satisfying linting requirements.
Closes: #7383
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test