feat(source): allow to register all pods and their associated PTR record #4782

foyerunix · 2024-10-01T11:54:23Z

Hello,

We have deployed multiples Kubernetes clusters on-premise. Our cluster use Cilium CNI with SNAT disabled. This mean the pods traffic will exit the cluster with their pod IP and not with the node IP (the pod IPs are then correctly routed back to Kubernetes).

This is useful for us as a SRE team as we can track easily which pod is making which connection.
The drawback is that we still have to check on Kubernetes the pod which is associated with a particular IP.

As external-dns already implemented the pod source and the creation of PTR record, I thought it would be easy to register the pods PTR record in the DNS. But the pod source seem to has been made for a very precise use case relating to kops.

I therefore implemented two new options for our use case:

--ignore-non-host-network-pods
--pod-source-domain

The first let us create DNS records for pods even if they aren't running with host networking enabled.
The second allow us to build a pod FQDN with a default domain even without annotations.

I'm hesitating to combine the two as only one option ("--all-pods-domain" ?) that would then bypass the original intended use case for the pod source. I worry that the combination of the kops use case and mine in the same configuration will lead to an absurd behavior. But what if someone have a legitimate use for this ?

Please can you give me your opinion on the current implementation or if you would want to refactor it in another way.

Best Regards.

linux-foundation-easycla · 2024-10-01T11:54:27Z

The committers listed above are authorized under a signed CLA.

✅ login: foyerunix (bf8c4c0)

k8s-ci-robot · 2024-10-01T11:54:32Z

Welcome @foyerunix!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-10-01T11:54:32Z

Hi @foyerunix. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2024-12-31T10:52:00Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

foyerunix · 2025-01-03T11:42:46Z

/remove-lifecycle stale

mloiseleur · 2025-01-10T08:03:56Z

/ok-to-test
@foyerunix The code LGTM. Would you please include in this PR documentation changes on docs/annotations/annotations.md and docs/tutorials/kops-dns-controller.md that are in #3174 ?

foyerunix · 2025-01-13T07:32:59Z

Hello @mloiseleur,

I included the requested documentation changes and I fixed the failing test.

Best Regards.

mloiseleur · 2025-01-13T15:45:56Z

/retitle feat(source): allow to register all pods and their associated PTR record

source/pod.go

Add two new options: - --ignore-non-host-network-pods - --pod-source-domain Combined toghether, they can be used to register the IPs of all pods with their associated PTR record. Co-authored-by: Michel Loiseleur <[email protected]>

foyerunix · 2025-01-14T07:32:29Z

Hello @mloiseleur,

Thanks for your input.
I included it, fixed a linting issue, and squashed everything.

Best Regards.

mloiseleur · 2025-01-15T07:22:32Z

/lgtm

ivankatliarchuk · 2025-01-16T12:14:55Z

From the implemenentation no question. Looks ok.

But there are concerns around actual feature itself related but there is a problem on how certain things where implemented.

ivankatliarchuk · 2025-01-16T12:16:44Z

I might missing or, not clear from flags itself.

What if I don't want this behaviour in my current setup? Will it work as is if I'm not adding any of this tags?

ivankatliarchuk · 2025-01-16T12:27:28Z

/assign

foyerunix · 2025-01-17T12:45:21Z

Hello @ivankatliarchuk,

My PR should not change the current behavior if we don't set the --no-ignore-non-host-network-pods flag. If I did change the current behavior, I would consider this an error that I have to fix.

Regarding the debate on whether IPv6 internal node IPs should be parsed as external also, I don't have a strong opinion, especially as I run an IPv4-only stack. However, I fail to see why my PR would change the current behavior for IPv6 nodes and pods.

As for PR #3174, I understood that the issue pointed out by @szuecs was that it wasn't properly shielded against a change in the current behavior, as it didn't have a feature flag to enable it. Therefore, a user who mistakenly set the annotation on some pods would have seen them being processed by External-DNS. Something that could happen for example in an Helm chart mixing HostNetwork and non-Hostnetwork pods.

Best Regards.

ivankatliarchuk

/lgtm

cc: @mloiseleur

mloiseleur · 2025-01-28T15:28:07Z

/approve

k8s-ci-robot · 2025-01-28T15:28:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…o v0.16.1 (#667) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | minor | `v0.15.1` -> `v0.16.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.16.1`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.16.1) [Compare Source](kubernetes-sigs/external-dns@v0.16.0...v0.16.1) This release fixes the breaking change introduced in v0.16.0 for Cloudflare. :warning: New features on Cloudflare, custom and regional hostnames have some known issues, see [#5175](kubernetes-sigs/external-dns#5175) and [#5183](kubernetes-sigs/external-dns#5183) :warning: OpenStack designate in-tree provider will be removed in the next version. There is now a [webhook provider](https://github.com/inovex/external-dns-openstack-webhook). :information_source: With v0.16.0, a new option on TXT Registry is available to use only new format ([#4946](kubernetes-sigs/external-dns#4946)). Previous format will be removed in the next release ([#5172](kubernetes-sigs/external-dns#5172)). #### 🐛 Bug fixes - fix(cloudflare): optional custom hostnames by [@mrozentsvayg](https://github.com/mrozentsvayg) in kubernetes-sigs/external-dns#5146 - fix(source): pass GatewayName to config by [@buroa](https://github.com/buroa) in kubernetes-sigs/external-dns#5169 - fix(cloudflare): infinite loop with more than 50 custom hostnames by [@mrozentsvayg](https://github.com/mrozentsvayg) in kubernetes-sigs/external-dns#5181 #### 📦 Others - chore: update OWNERS with required config file by [@mloiseleur](https://github.com/mloiseleur) in kubernetes-sigs/external-dns#5164 **Full Changelog**: kubernetes-sigs/external-dns@v0.16.0...v0.16.1 ### [`v0.16.0`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.16.0) [Compare Source](kubernetes-sigs/external-dns@v0.15.1...v0.16.0) #### 💥 Breaking Changes There is a [breaking change on Cloudflare](kubernetes-sigs/external-dns#5166) with this release. It requires Cloudflare for Saas. #### 🚀 Features - feat: add dreamhost webook provider to readme ([#5015](kubernetes-sigs/external-dns#5015)) [@asymingt](https://github.com/asymingt) - feat: Add F5 TransportServer source ([#4944](kubernetes-sigs/external-dns#4944)) [@visokoo](https://github.com/visokoo) - feat(chart): allow to run tpl on `ServiceAccount` annotations ([#4958](kubernetes-sigs/external-dns#4958)) ([#4958](kubernetes-sigs/external-dns#4958)) [@fcrespofastly](https://github.com/fcrespofastly) - feat(cloudflare): custom hostname and fix apex ([#5087](kubernetes-sigs/external-dns#5087)) [@mrozentsvayg](https://github.com/mrozentsvayg) - feat(deps): added renovate config for custom regexes ([#4978](kubernetes-sigs/external-dns#4978)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - feat: don't discard klog logs at the highest log levels (debug and trace) ([#4961](kubernetes-sigs/external-dns#4961)) [@dmarkhas](https://github.com/dmarkhas) - feat(pdns): add validation for MX and SRV records ([#4871](kubernetes-sigs/external-dns#4871)) [@julillae](https://github.com/julillae) - feat(rfc2136): support multiple hosts ([#4653](kubernetes-sigs/external-dns#4653)) [@Jeremy-Boyle](https://github.com/Jeremy-Boyle) - feat(service): listen to endpoint changes ([#5085](kubernetes-sigs/external-dns#5085)) [@dmarkhas](https://github.com/dmarkhas) - feat(source): allow to register all pods and their associated PTR record ([#4782](kubernetes-sigs/external-dns#4782)) [@foyerunix](https://github.com/foyerunix) - feat(txt-registry): add option to use only new format ([#4946](kubernetes-sigs/external-dns#4946)) [@malpou](https://github.com/malpou) #### 🐛 Bug fixes - fix(aes-encryption): support plain txt and url safe base64 strings ([#4980](kubernetes-sigs/external-dns#4980)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - fix(aws-provider): ListTagsForResource incorrect zone-id handling ([#5029](kubernetes-sigs/external-dns#5029)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - fix(chart): non-string types on svcaccount annotations ([#5067](kubernetes-sigs/external-dns#5067)) [@hjoshi123](https://github.com/hjoshi123) - fix(chart): regression with affinity.nodeAffinity getting ignored ([#5046](kubernetes-sigs/external-dns#5046)) [@mkhpalm](https://github.com/mkhpalm) - fix(chart): update rbac for F5 transportserver source ([#5066](kubernetes-sigs/external-dns#5066)) ([#5066](kubernetes-sigs/external-dns#5066)) [@visokoo](https://github.com/visokoo) - fix(cloudflare): add more descriptive log message ([#5047](kubernetes-sigs/external-dns#5047)) [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) - fix(cloudflare): use softerror on internal server error with api ([#4931](kubernetes-sigs/external-dns#4931)) [@vishuvenu](https://github.com/vishuvenu) - fix(dedup): records with different type are not duplicates ([#4889](kubernetes-sigs/external-dns#4889)) [@jtszalay](https://github.com/jtszalay) - fix(docs): aws tutorial broken internal markdown links ([#5036](kubernetes-sigs/external-dns#5036)) [@strophy](https://github.com/strophy) - fix: do not merge CNAME with multiple targets ([#4856](kubernetes-sigs/external-dns#4856)) [@dtuck9](https://github.com/dtuck9) - fix(f5-virtualserver): skip endpoint creation when VirtualServer is not ready ([#4996](kubernetes-sigs/external-dns#4996)) [@mikejoh](https://github.com/mikejoh) - fix(godaddy): Handle missing Retry-After header gracefully ([#4866](kubernetes-sigs/external-dns#4866)) [@alexstojda](https://github.com/alexstojda) - fix(oci): records with multiple IP addresses ([#4993](kubernetes-sigs/external-dns#4993)) [@jrosinsk](https://github.com/jrosinsk) - fix(ovh): cache refresh and duplicates processing ([#4932](kubernetes-sigs/external-dns#4932)) [@nmaupu](https://github.com/nmaupu) - fix(registry): handle empty targets in TXT records logging an error ([#5149](kubernetes-sigs/external-dns#5149)) [@saikatharryc](https://github.com/saikatharryc) - fix(source): allow ipv4-mapped ipv6 addresses ([#4943](kubernetes-sigs/external-dns#4943)) [@buroa](https://github.com/buroa) - fix(source): debug log on gateway target detection ([#5096](kubernetes-sigs/external-dns#5096)) [@drcapulet](https://github.com/drcapulet) - Fix spelling in webhook OpenAPI spec ([#5038](kubernetes-sigs/external-dns#5038)) [@claycooper](https://github.com/claycooper) - fix: use informer for istio gateways ([#4522](kubernetes-sigs/external-dns#4522)) [@woehrl01](https://github.com/woehrl01) #### 📝 Documentation - docs: add deprecation policy ([#5053](kubernetes-sigs/external-dns#5053)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs: add staging images to release process ([#5050](kubernetes-sigs/external-dns#5050)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs: fix typo on aws tutorial ([#5070](kubernetes-sigs/external-dns#5070)) [@Ileriayo](https://github.com/Ileriayo) - docs: fix typos in tutorials ([#4969](kubernetes-sigs/external-dns#4969)) [@mloiseleur](https://github.com/mloiseleur) - docs(Microsoft DNS): improve instructions ([#4893](kubernetes-sigs/external-dns#4893)) [@TomyLobo](https://github.com/TomyLobo) - docs(proposal): standartise date format ([#5128](kubernetes-sigs/external-dns#5128)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs(proposal): update template with statuses ([#5098](kubernetes-sigs/external-dns#5098)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs(provider): add ClouDNS to README ([#5065](kubernetes-sigs/external-dns#5065)) [@rwunderer](https://github.com/rwunderer) - docs(README): fix link to dev guide ([#5116](kubernetes-sigs/external-dns#5116)) [@masterkain](https://github.com/masterkain) - docs(registry): fix managed-record-type argument ([#5102](kubernetes-sigs/external-dns#5102)) [@splitice](https://github.com/splitice) - docs: update and refactor contribution part ([#5073](kubernetes-sigs/external-dns#5073)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - ci(docs): add markdown linters and editorconfig ([#5055](kubernetes-sigs/external-dns#5055)) [@mloiseleur](https://github.com/mloiseleur) - Improve sources' docs to mention '--managed-record-types' ([#4882](kubernetes-sigs/external-dns#4882)) [@juan-vg](https://github.com/juan-vg) #### 📦 Others - add: auto label source and providers ([#5158](kubernetes-sigs/external-dns#5158)) [@szuecs](https://github.com/szuecs) - Add OpenStack Designate webook provider to readme ([#5115](kubernetes-sigs/external-dns#5115)) [@frittentheke](https://github.com/frittentheke) - chore(ci): fix and sort changelog ([#4979](kubernetes-sigs/external-dns#4979)) [@mloiseleur](https://github.com/mloiseleur) dependabot - chore(ci): fix failing test, upgrade to go 1.23.5 and linter to v1.63 ([#5013](kubernetes-sigs/external-dns#5013)) [@mloiseleur](https://github.com/mloiseleur) - chore(ci): remove too slow test ([#5014](kubernetes-sigs/external-dns#5014)) [@mloiseleur](https://github.com/mloiseleur) - chore(deps): bump actions/setup-python from 5.3.0 to 5.4.0 in the dev-dependencies group ([#5041](kubernetes-sigs/external-dns#5041)) [@dependabot](https://github.com/dependabot) - chore(deps): bump azure/setup-helm from 4.2.0 to 4.3.0 in the dev-dependencies group ([#5108](kubernetes-sigs/external-dns#5108)) [@dependabot](https://github.com/dependabot) - chore(deps): bump helm/kind-action from 1.10.0 to 1.11.0 in the dev-dependencies group ([#4956](kubernetes-sigs/external-dns#4956)) [@dependabot](https://github.com/dependabot) - chore(deps): bump helm/kind-action from 1.11.0 to 1.12.0 in the dev-dependencies group ([#4972](kubernetes-sigs/external-dns#4972)) [@dependabot](https://github.com/dependabot) - chore(deps): bump nosborn/github-action-markdown-cli from 3.3.0 to 3.4.0 in the dev-dependencies group ([#5083](kubernetes-sigs/external-dns#5083)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 14 updates ([#4976](kubernetes-sigs/external-dns#4976)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 18 updates ([#5040](kubernetes-sigs/external-dns#5040)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 20 updates ([#4999](kubernetes-sigs/external-dns#4999)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 21 updates ([#5089](kubernetes-sigs/external-dns#5089)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 22 updates ([#5062](kubernetes-sigs/external-dns#5062)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 23 updates ([#5145](kubernetes-sigs/external-dns#5145)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 25 updates ([#5023](kubernetes-sigs/external-dns#5023)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 5 updates ([#4987](kubernetes-sigs/external-dns#4987)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 7 updates ([#5125](kubernetes-sigs/external-dns#5125)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 20 updates ([#5109](kubernetes-sigs/external-dns#5109)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 2 updates ([#5022](kubernetes-sigs/external-dns#5022)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 3 updates ([#5112](kubernetes-sigs/external-dns#5112)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 4 updates ([#4988](kubernetes-sigs/external-dns#4988)) [@dependabot](https://github.com/dependabot) - chore(docs): docs/flags.md generation ([#4983](kubernetes-sigs/external-dns#4983)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(filter-tags): pre-process filter tags ([#5063](kubernetes-sigs/external-dns#5063)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(makefile): add helper and document targets ([#5093](kubernetes-sigs/external-dns#5093)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(makefile): simplify coverage script ([#5105](kubernetes-sigs/external-dns#5105)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(provider-aws): improve canonicalHostedZone handling ([#5031](kubernetes-sigs/external-dns#5031)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(release): publish chart v1.15.2 ([#5094](kubernetes-sigs/external-dns#5094)) [@stevehipwell](https://github.com/stevehipwell) - chore: update maintainers/reviewers ([#5020](kubernetes-sigs/external-dns#5020)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore: upgrade ExternalDNS to go 1.24 ([#5106](kubernetes-sigs/external-dns#5106)) [@mloiseleur](https://github.com/mloiseleur) - kustomize-v0.15.1 ([#4966](kubernetes-sigs/external-dns#4966)) [@Raffo](https://github.com/Raffo) - Release Helm chart for `v0.15.1` ([#5028](kubernetes-sigs/external-dns#5028)) [@stevehipwell](https://github.com/stevehipwell) - replace all versions to v0.15.1 ([#4973](kubernetes-sigs/external-dns#4973)) [@Raffo](https://github.com/Raffo) - test(cloudflare): add scenarios on submitChanges ([#5054](kubernetes-sigs/external-dns#5054)) [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) - test(domain-filter): simple filters on domain exclusion ([#5064](kubernetes-sigs/external-dns#5064)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - test(provider): tags filter coverage and benchmark ([#5060](kubernetes-sigs/external-dns#5060)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) #### New Contributors - [@juan-vg](https://github.com/juan-vg) made their first contribution in kubernetes-sigs/external-dns#4882 - [@dmarkhas](https://github.com/dmarkhas) made their first contribution in kubernetes-sigs/external-dns#4961 - [@buroa](https://github.com/buroa) made their first contribution in kubernetes-sigs/external-dns#4943 - [@fcrespofastly](https://github.com/fcrespofastly) made their first contribution in kubernetes-sigs/external-dns#4958 - [@nmaupu](https://github.com/nmaupu) made their first contribution in kubernetes-sigs/external-dns#4932 - [@dtuck9](https://github.com/dtuck9) made their first contribution in kubernetes-sigs/external-dns#4856 - [@asymingt](https://github.com/asymingt) made their first contribution in kubernetes-sigs/external-dns#5015 - [@alexstojda](https://github.com/alexstojda) made their first contribution in kubernetes-sigs/external-dns#4866 - [@visokoo](https://github.com/visokoo) made their first contribution in kubernetes-sigs/external-dns#4944 - [@vishuvenu](https://github.com/vishuvenu) made their first contribution in kubernetes-sigs/external-dns#4931 - [@TomyLobo](https://github.com/TomyLobo) made their first contribution in kubernetes-sigs/external-dns#4893 - [@strophy](https://github.com/strophy) made their first contribution in kubernetes-sigs/external-dns#5036 - [@malpou](https://github.com/malpou) made their first contribution in kubernetes-sigs/external-dns#4946 - [@foyerunix](https://github.com/foyerunix) made their first contribution in kubernetes-sigs/external-dns#4782 - [@rwunderer](https://github.com/rwunderer) made their first contribution in kubernetes-sigs/external-dns#5065 - [@Ileriayo](https://github.com/Ileriayo) made their first contribution in kubernetes-sigs/external-dns#5070 - [@hjoshi123](https://github.com/hjoshi123) made their first contribution in kubernetes-sigs/external-dns#5067 - [@mkhpalm](https://github.com/mkhpalm) made their first contribution in kubernetes-sigs/external-dns#5046 - [@woehrl01](https://github.com/woehrl01) made their first contribution in kubernetes-sigs/external-dns#4522 - [@jtszalay](https://github.com/jtszalay) made their first contribution in kubernetes-sigs/external-dns#4889 - [@splitice](https://github.com/splitice) made their first contribution in kubernetes-sigs/external-dns#5102 - [@drcapulet](https://github.com/drcapulet) made their first contribution in kubernetes-sigs/external-dns#5096 - [@mrozentsvayg](https://github.com/mrozentsvayg) made their first contribution in kubernetes-sigs/external-dns#5087 - [@frittentheke](https://github.com/frittentheke) made their first contribution in kubernetes-sigs/external-dns#5115 - [@masterkain](https://github.com/masterkain) made their first contribution in kubernetes-sigs/external-dns#5116 - [@renanqts](https://github.com/renanqts) made their first contribution in kubernetes-sigs/external-dns#5132 - [@rlees85](https://github.com/rlees85) made their first contribution in kubernetes-sigs/external-dns#5111 - [@stefaneg](https://github.com/stefaneg) made their first contribution in kubernetes-sigs/external-dns#5135 - [@saikatharryc](https://github.com/saikatharryc) made their first contribution in kubernetes-sigs/external-dns#5149 **Full Changelog**: kubernetes-sigs/external-dns@v0.15.1...v0.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/667 Co-authored-by: JesusMtnez-bot <[email protected]> Co-committed-by: JesusMtnez-bot <[email protected]>

k8s-ci-robot requested review from mloiseleur and szuecs October 1, 2024 11:54

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 1, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2025

foyerunix mentioned this pull request Jan 3, 2025

feat: allow pod IPs even for non-hostNetwork pods #3174

Closed

2 tasks

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2025

foyerunix force-pushed the reverse-for-all-pods branch from df15bec to ee3887a Compare January 13, 2025 07:10

k8s-ci-robot changed the title ~~Allow to register all pods and their associated PTR record~~ feat(source): allow to register all pods and their associated PTR record Jan 13, 2025

mloiseleur reviewed Jan 13, 2025

View reviewed changes

source/pod.go Outdated Show resolved Hide resolved

foyerunix force-pushed the reverse-for-all-pods branch from 2235612 to bf8c4c0 Compare January 14, 2025 07:24

k8s-ci-robot assigned mloiseleur Jan 15, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025

k8s-ci-robot assigned ivankatliarchuk Jan 16, 2025

ivankatliarchuk approved these changes Jan 28, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025

k8s-ci-robot merged commit a617802 into kubernetes-sigs:master Jan 28, 2025
13 checks passed

feat(source): allow to register all pods and their associated PTR record #4782

feat(source): allow to register all pods and their associated PTR record #4782

Uh oh!

Conversation

foyerunix commented Oct 1, 2024

Uh oh!

linux-foundation-easycla bot commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 1, 2024

Uh oh!

k8s-ci-robot commented Oct 1, 2024

Uh oh!

k8s-triage-robot commented Dec 31, 2024

Uh oh!

foyerunix commented Jan 3, 2025

Uh oh!

mloiseleur commented Jan 10, 2025

Uh oh!

foyerunix commented Jan 13, 2025

Uh oh!

mloiseleur commented Jan 13, 2025

Uh oh!

Uh oh!

foyerunix commented Jan 14, 2025

Uh oh!

mloiseleur commented Jan 15, 2025

Uh oh!

ivankatliarchuk commented Jan 16, 2025

Uh oh!

ivankatliarchuk commented Jan 16, 2025

Uh oh!

ivankatliarchuk commented Jan 16, 2025

Uh oh!

foyerunix commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivankatliarchuk left a comment

Choose a reason for hiding this comment

Uh oh!

mloiseleur commented Jan 28, 2025

Uh oh!

k8s-ci-robot commented Jan 28, 2025

Uh oh!

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Oct 1, 2024 •

edited

Loading

foyerunix commented Jan 17, 2025 •

edited

Loading