Skip to content

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented May 17, 2025

Description

Added a mkdocs plugin, that helps to capture snippets in single folder, this should simplify user experience, and no need to browse all the documents.

benefits for adding plugin

  • central place for all examples in docs
  • we could generate raw files and embedd them into pages. Current approach require to manage/generate whole .md page, which is adds complexity
  • json and yaml validators will be able to validate files/snippets
  • should help to standartise examples, snippets

The idea is taken from external secrets operator . The only different they have a flat structure https://github.com/external-secrets/external-secrets/tree/main/docs/snippets. I have no preference on structure

Examples (validated is working)
Screenshot 2025-05-17 at 10 40 08

updated docs

Screenshot 2025-05-17 at 11 14 49

example failed yml/json validator (we could ofcourse exlude it if required)

Screenshot 2025-05-17 at 11 22 22

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from mloiseleur and szuecs May 17, 2025 10:17
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 17, 2025
@ivankatliarchuk ivankatliarchuk force-pushed the docs-mkdocs-macros branch 2 times, most recently from 6b450e1 to 253ff73 Compare May 17, 2025 10:31
@ivankatliarchuk
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 17, 2025
ivankatliarchuk and others added 2 commits May 19, 2025 08:46
Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 84a0c64 into kubernetes-sigs:master May 19, 2025
14 checks passed
@ivankatliarchuk ivankatliarchuk deleted the docs-mkdocs-macros branch May 19, 2025 08:46
@mloiseleur mloiseleur mentioned this pull request Sep 2, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants