Skip to content

Conversation

mloiseleur
Copy link
Collaborator

@mloiseleur mloiseleur commented Sep 2, 2025

What does it do ?

Fix mkdocs configuration on README.md and chart CHANGELOG.md that was broken since this PR and triggered by this other PR.

Motivation

Build with mkdocs failed with this error:

WARNING -  [macros] - ERROR # _Macro Syntax Error_

           _File_: `README.md`

           _Line 162 in Markdown file:_ **Missing end of comment tag**
           ```markdown
           - [v0.10.0](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.10.0): use of `networking.k8s.io/ingresses` instead of
           `extensions/ingresses` (see [#2281](https://github.com/kubernetes-sigs/external-dns/pull/2281))
           ```

WARNING -  [macros] - ERROR # _Macro Syntax Error_

           _File_: `charts/external-dns/CHANGELOG.md`

           _Line 23 in Markdown file:_ **Missing end of comment tag**
           ```markdown
           - Add option to configure `annotationFilter` via dedicated chart value. ([#5737](https://github.com/kubernetes-sigs/external-dns/pull/5737))
           _@dshatokhin_
           ```

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2025
@k8s-ci-robot k8s-ci-robot added chart size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@k8s-ci-robot k8s-ci-robot added docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2025
@ivankatliarchuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@mloiseleur mloiseleur changed the title docs: fix mkdoc build docs: fix mkdocs build Sep 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 04ef733 into kubernetes-sigs:master Sep 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants