fix(source/node): template expansion

[ivankatliarchuk]

What does it do ?

Motivation

Fixes #3408 #4232

based on pull request #3409

• I've created a separate file for fqdn testing. This will simplify sharing examples how to use it per service. I'll try to think off how to create documentation for fqdn from tests

Follow-up:

• automate documentation/example update for fqdn with sources
• node endpoints do not have source label. Need to be fixed. feat(source): add resouce labels for nodes #5509
• filter by annotation is not tested, it seems working, but worth to add tests
• support combineFQDNAnnotation. feat(source/node): fqdn support combineFQDNAnnotation #5526
• annotations.ProviderSpecificAnnotations not supported on node level

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[mloiseleur]

It looks like a fix to me :)

[mloiseleur]

@jordo Can you confirm that this PR fixes your issue ? If needed, see how to test a PR ?

[ivankatliarchuk]

@jordo Can you confirm that this PR fixes your issue ? If needed, see how to test a PR ?

Heh, yeah was thinking same.
I'll also ping @Cubixmeister, @fredrikgh you too may be interested in this feature

[ivankatliarchuk]

I've also added quite few unit test, to improve node/fqdn look and feel

[ivankatliarchuk]

Hi @TilBlechschmidt not sure if still interested, but I found an issue from you as well #4232

[TilBlechschmidt]

Hey @ivankatliarchuk, thanks for the mention and fix! We worked around the issue for now but having a fix for it is really nice to have for the future 👌

[mloiseleur]

/lgtm

[ivankatliarchuk]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ivankatliarchuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivankatliarchuk]

/test pull-external-dns-unit-test

[ivankatliarchuk]

/retest-required