feat(source): add resouce labels for nodes#5509
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Jun 9, 2025
Merged
feat(source): add resouce labels for nodes#5509k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
mloiseleur
changed the title
Collaborator
|
It looks like more a feat than a chore to me :). |
k8s-ci-robot
added
the
lgtm
Member
Author
|
Yeah. Need to be better with feat/chore things |
Member
Author
|
Tested on dummy cluster with nodes that have quite lengty names eks nodes 
|
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 tasks
Member
Author
|
/test pull-external-dns-unit-test |
3 tasks
Member
Author
|
/retest-required |
Closed
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Jun 10, 2025
* master: test(source): fix flaky test (kubernetes-sigs#5514) chore(source/node): added resouce labels for nodes (kubernetes-sigs#5509) chore(deps): bump the dev-dependencies group across 1 directory with 14 updates (kubernetes-sigs#5511) fix(ovh): correct handling of records deletion (kubernetes-sigs#5450)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
This is a follow-up for PR #5498
Motivation
The more standart we have config accross different sources, easier to maintain them
More