Add istio provider by dpasiukevich · Pull Request #111 · kubernetes-sigs/ingress2gateway

dpasiukevich · 2023-12-27T17:35:18Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add istio provider which does Istio API (Gateway & VirtualService) -> K8S Gateway API conversion

Which issue(s) this PR fixes:

Fixes #100

Does this PR introduce a user-facing change?:

Add support for Istio API conversion to K8S Gateway API

k8s-ci-robot · 2023-12-27T17:35:20Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

LiorLieberman

Thanks for this awesome PR!

I finished first round of reviews.

I think we need @howardjohn for the ins and outs of the logic.

Also - as we are now in 2024 - do you mind have another commit that changes only the new files you added to 2024?

/cc @howardjohn

howardjohn

Nice work!

dpasiukevich

I'd addresses all the comments, besides the rewrite filter which would be updated later.

If there's a rewrite in istio.HTTPRoute and it has different match types (prefix and full/regex), then I'd aggregate matches and generate 2 k8sgw.HTTPRoutes (one with Prefix and the other with FullPath) rewrite filter

LiorLieberman · 2024-01-08T11:31:47Z

Awesome work!
Thanks for working on this.

/hold

/lgtm
/approve

k8s-ci-robot · 2024-01-08T11:31:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dpasiukevich, howardjohn, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LiorLieberman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LiorLieberman · 2024-01-08T11:33:59Z

Holding because I wanted to let you choose whether you think it is more appropriate to merge this commit with all the commit messages. (then add /label tide/merge-method-merge). Otherwise if you want to robot to squash it, just remove the hold

dpasiukevich · 2024-01-08T12:26:03Z

@LiorLieberman thanks! I've kept the commit chain as it's structured finely (only squashed the last commit). Could you re-lgtm?

/unhold

LiorLieberman · 2024-01-08T12:31:43Z

/label tide/merge-method-merge

LiorLieberman · 2024-01-08T12:31:58Z

/lgtm

Add istio provider

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 27, 2023

k8s-ci-robot requested review from Xunzhuo and mlavacca December 27, 2023 17:35

dpasiukevich temporarily deployed to release December 27, 2023 17:35 — with GitHub Actions Inactive

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 27, 2023

dpasiukevich force-pushed the istio_provider branch from 25b1df7 to 96c3947 Compare December 27, 2023 18:56

dpasiukevich temporarily deployed to release December 27, 2023 18:56 — with GitHub Actions Inactive

dpasiukevich force-pushed the istio_provider branch from 96c3947 to 2293259 Compare December 30, 2023 16:05

dpasiukevich temporarily deployed to release December 30, 2023 16:05 — with GitHub Actions Inactive

dpasiukevich marked this pull request as ready for review December 30, 2023 16:09

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2023

dpasiukevich force-pushed the istio_provider branch from 2293259 to a9d4a76 Compare December 30, 2023 16:15

dpasiukevich temporarily deployed to release December 30, 2023 16:15 — with GitHub Actions Inactive

LiorLieberman reviewed Jan 2, 2024

View reviewed changes

k8s-ci-robot requested a review from howardjohn January 2, 2024 09:54

howardjohn approved these changes Jan 2, 2024

View reviewed changes

dpasiukevich temporarily deployed to release January 3, 2024 14:10 — with GitHub Actions Inactive

dpasiukevich commented Jan 3, 2024

View reviewed changes

dpasiukevich temporarily deployed to release January 3, 2024 18:47 — with GitHub Actions Inactive

dpasiukevich force-pushed the istio_provider branch from ce7e0bb to e39d712 Compare January 3, 2024 18:48

dpasiukevich temporarily deployed to release January 3, 2024 18:48 — with GitHub Actions Inactive

dpasiukevich added 6 commits January 5, 2024 13:10

Istio provider: add Istio Gateway translation.

6901907

Istio provider: add Istio VirtualService HTTPRoute translation.

eb44388

Istio provider: add Istio VirtualService TLS&TCP translation.

f8abfd3

Istio provider: generate parentRefs and ReferenceGrants.

54a0760

Istio provider: add e2e test with file examples/fixtures.

875cd77

Istio provider: add/update READMEs

fe7b98f

dpasiukevich added 3 commits January 5, 2024 13:10

Istio provider: register provider.

c018607

Istio provider: return translation error on unexpected conditions.

e815ded

Istio provider: translate istio rewrite clause.

3bef02b

dpasiukevich force-pushed the istio_provider branch from e39d712 to 2c1f37e Compare January 5, 2024 13:14

dpasiukevich temporarily deployed to release January 5, 2024 13:14 — with GitHub Actions Inactive

LiorLieberman reviewed Jan 5, 2024

View reviewed changes

Comment thread pkg/i2gw/providers/istio/README.md

Comment thread pkg/i2gw/providers/istio/README.md Outdated

Comment thread pkg/i2gw/providers/istio/converter.go

dpasiukevich temporarily deployed to release January 5, 2024 21:44 — with GitHub Actions Inactive

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024

k8s-ci-robot assigned LiorLieberman Jan 8, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024

Istio provider: handle rewrite when there's no path matches.

4d93827

dpasiukevich force-pushed the istio_provider branch from 8ef69a9 to 4d93827 Compare January 8, 2024 12:12

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024

dpasiukevich temporarily deployed to release January 8, 2024 12:12 — with GitHub Actions Inactive

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024

k8s-ci-robot added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Jan 8, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024

k8s-ci-robot merged commit 742bb82 into kubernetes-sigs:main Jan 8, 2024

rajashish pushed a commit to rajashish/ingress2gateway1 that referenced this pull request Feb 21, 2026

Merge pull request kubernetes-sigs#111 from dpasiukevich/istio_provider

45bad96

Add istio provider

Conversation

dpasiukevich commented Dec 27, 2023

Uh oh!

k8s-ci-robot commented Dec 27, 2023

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

howardjohn left a comment

Choose a reason for hiding this comment

Uh oh!

dpasiukevich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiorLieberman commented Jan 8, 2024

Uh oh!

k8s-ci-robot commented Jan 8, 2024

Uh oh!

LiorLieberman commented Jan 8, 2024

Uh oh!

dpasiukevich commented Jan 8, 2024

Uh oh!

LiorLieberman commented Jan 8, 2024

Uh oh!

LiorLieberman commented Jan 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants