Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Contributor
Author
|
/assign @LiorLieberman |
sawsa307
force-pushed
the
add-ingress-class
branch
from
8a646b6 to
b4766aa
Compare
k8s-ci-robot
added
size/M
sawsa307
force-pushed
the
add-ingress-class
branch
from
b4766aa to
f2bfeab
Compare
k8s-ci-robot
added
size/L
sawsa307
force-pushed
the
add-ingress-class
branch
from
ea877af to
60c0f26
Compare
Member
|
Thanks David, mind adding a test for it? |
Member
|
/cc |
sawsa307
force-pushed
the
add-ingress-class
branch
from
60c0f26 to
681cc3d
Compare
Contributor
Author
Just added one. Please take a look! |
k8s-ci-robot
added
size/S
sawsa307
force-pushed
the
add-ingress-class
branch
from
681cc3d to
0ed6c46
Compare
sawsa307
force-pushed
the
add-ingress-class
branch
from
0ed6c46 to
05b9548
Compare
sawsa307
force-pushed
the
add-ingress-class
branch
from
05b9548 to
5626560
Compare
levikobi
reviewed
Jul 21, 2024
* Translation uses the ingressClassName to determine the Gateway name. GKE supports empty ingress class name, which would default to be external Ingress. * However, it allows the resulting Gateway to have no name. Thus, we should manually patch the ingress class name for those Ingresses that do not specify the ingress class name annotation. * The patching will happen during resource read, so we won't run into situation that converts an GKE Ingress without Ingress class name. It should either be gce or gce-internal.
sawsa307
force-pushed
the
add-ingress-class
branch
from
5626560 to
ce09d6e
Compare
Member
LiorLieberman
left a comment
LiorLieberman
left a comment
There was a problem hiding this comment.
Thank you david!
/approve
/lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, sawsa307 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rajashish
pushed a commit
to rajashish/ingress2gateway1
that referenced
this pull request
Feb 21, 2026
* Run go mod tidy && go mod vendor * Manually add ingressClassName for GCE Ingress that has empty class name. * Translation uses the ingressClassName to determine the Gateway name. GKE supports empty ingress class name, which would default to be external Ingress. * However, it allows the resulting Gateway to have no name. Thus, we should manually patch the ingress class name for those Ingresses that do not specify the ingress class name annotation. * The patching will happen during resource read, so we won't run into situation that converts an GKE Ingress without Ingress class name. It should either be gce or gce-internal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Make sure Gateway name is not empty when the GKE ingress class name is not specified.
Which issue(s) this PR fixes:
Fixes #87
Does this PR introduce a user-facing change?: