Skip to content

Add notification support for GCE.#169

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sawsa307:gce-notification
Jul 22, 2024
Merged

Add notification support for GCE.#169
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sawsa307:gce-notification

Conversation

@sawsa307
Copy link
Copy Markdown
Contributor

@sawsa307 sawsa307 commented Jul 16, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add notification support for GCE.

Which issue(s) this PR fixes:

Fixes #87

Does this PR introduce a user-facing change?:

GCE now will display useful information generated during conversion process via the new notification package.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot requested review from Xunzhuo and levikobi July 16, 2024 16:42
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2024
@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Jul 16, 2024

/assign @LiorLieberman

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2024
@sawsa307 sawsa307 changed the title Gce notification Add notification support for GCE. Jul 16, 2024
@LiorLieberman
Copy link
Copy Markdown
Member

LiorLieberman commented Jul 22, 2024

This seems to include changes that are included in other #167.
Can you rebase?

@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Jul 22, 2024

This seems to include changes that are included in other #167. Can you rebase?

Rebased, PTAL!

LiorLieberman
LiorLieberman reviewed Jul 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks.
I left one comment

/approve

Comment thread pkg/i2gw/providers/gce/implementation_specific.go Outdated
currentValue := *path.Value
path.Type = &pmPrefix
path.Value = common.PtrTo(strings.TrimSuffix(*path.Value, "/*"))
notify(notifications.WarningNotification, fmt.Sprintf("After conversion, ImplementationSpecific Path %s/* will additionally map to %s. See README.md for details.", currentValue, *path.Value))
Copy link
Copy Markdown
Member

@LiorLieberman LiorLieberman Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of README.md, provide a link to the Github to the readme, so the users can click on it

Copy link
Copy Markdown
Contributor Author

@sawsa307 sawsa307 Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that makes more sense. Updated both places, PTAL!

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, sawsa307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@LiorLieberman
Copy link
Copy Markdown
Member

LiorLieberman commented Jul 22, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 22, 2024
@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Jul 22, 2024

Just updated the description in the README. I think the discrepancy in ImplementationSpecific translation wasn't as obvious as it should be.

LiorLieberman
LiorLieberman reviewed Jul 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4ff3a4c into kubernetes-sigs:main Jul 22, 2024
rajashish pushed a commit to rajashish/ingress2gateway1 that referenced this pull request Feb 21, 2026
@sawsa307
Add notification support for gce. (kubernetes-sigs#169)
fbef219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiorLieberman LiorLieberman LiorLieberman left review comments

@levikobi levikobi Awaiting requested review from levikobi

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees

@LiorLieberman LiorLieberman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for GCE ingress class/provider

3 participants

@sawsa307 @LiorLieberman @k8s-ci-robot