feat: kgateway emitter by puertomontt · Pull Request #320 · kubernetes-sigs/ingress2gateway

puertomontt · 2026-01-26T15:34:35Z

What type of PR is this?

/kind feature

depends on #305

What this PR does / why we need it:

Add kgateway emitter.

Which issue(s) this PR fixes:

Fixes #260

Does this PR introduce a user-facing change?:

Add kgateway emitter

k8s-ci-robot · 2026-01-26T15:34:46Z

Hi @puertomontt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Stevenjin8 · 2026-01-28T20:52:39Z

/ok-to-test

Stevenjin8 · 2026-01-28T20:55:31Z

+	return filepath.Dir(goModPath)
+}
+
+func canonicalizeMultiDocYAML(t *testing.T, in []byte) []byte {


We've got integration tests in work, so we can probably do those tests here.

Stevenjin8 · 2026-01-28T20:56:18Z

Seems good, going to wait until @kkk777-7 PR merges first and #294

Stevenjin8 · 2026-02-08T19:09:16Z

@puertomontt could you add yourself to the owners file and agree to

ingress2gateway/docs/emitters.md

Lines 61 to 83 in 2802595

    
           ## Governance and Maintainability 
        
           To ensure long-term stability, we list clear expectations for Gateway API implementations that wish to have custom emitters in ingress2gateway. 
        
           * All code that serves a single vendor or implementation ("third-party code") MUST have nominated contacts for security that will respond within at most 3 business days, if we find security issues. 
        
           * All third-party code MUST live in individual directories/modules, with `CODEOWNERS` indicating who is responsible for reviewing that code. 
        
           * Reviews and issues about third-party code MUST be triaged and responded to within 30 days. 
        
           Furthermore, the codeowners of third-party emitters MUST commit to the following responsibilities: 
        
           * Update the third-party emitters to keep up with upstream Gateway API changes within 60 days of a new Gateway API release. 
        
           * Ensure that the output of third-party emitters matches the scope defined below within 60 days of a new Gateway API release. 
        
           Not keeping up with these responsibilities will trigger a removal process for the affected third-party emitters which is as follows: 
        
           * In the next minor release, the emitters will be marked as deprecated, triggering a warning to users. 
        
           * The emitters will be removed in the following minor release or within 30 days, whichever comes later. 
        
           * During this time, ingress2gateway maintainers will reach out to the codeowners with two emails spaced one week apart, notifying them of the impending removal as well as a GitHub issue. 
        
           A codeowner can stop the removal process if they demonstrate commitment to the above policy as decided by the maintainers. 
        
           Existing providers will be exempted from these policies, but may not be fully integrated into the provider/emitter model.

Stevenjin8 · 2026-02-08T19:13:12Z

@puertomontt Also, it would be nice to add some e2e tests, but we can have that in another PR (sooner rather than later hopefully)

puertomontt · 2026-02-09T16:18:29Z

@Stevenjin8 would it be alright to merge this first then add myself as an owner. I need one merged PR to request org membership

or if you sponsor me, can I be added to the org?

puertomontt · 2026-02-10T16:21:55Z

@Stevenjin8 I'll apply for org after this merges.

Stevenjin8 · 2026-02-10T16:37:50Z

@puertomontt happy to sponsor.

puertomontt · 2026-02-10T20:40:30Z

@Stevenjin8 can we merge this while waiting for me to be added to k8s sigs org? we have a lot of follow up PR we want to start on. Thanks

johananl · 2026-02-16T10:25:38Z

Fix: #349

puertomontt · 2026-02-16T22:58:36Z

@johananl @Stevenjin8 is this good to go now?

Stevenjin8 · 2026-02-16T23:15:35Z

@puetromontt PRs need two reviews (and approve and an lgtm) to merge. I already approved it. (But PRs from maintainer only need one)

johananl · 2026-02-17T10:51:56Z

@johananl @Stevenjin8 is this good to go now?

I haven't reviewed your code yet because make e2e wouldn't pass for me. Now that we merged #349 I can review the code.

Open-source projects rely very often on async communication. Please be patient 🙂

johananl · 2026-02-17T10:55:25Z

@puertomontt could you please rebase your branch on current main instead of merging? The PR contains many unrelated commits now.

johananl

Thank you for your contribution @puertomontt!

I left a few small comments/questions, the main one being about potentially unused code.

johananl · 2026-02-17T11:13:45Z

+		t.Run("basic conversion", func(t *testing.T) {
+			runTestCase(t, &testCase{
+				gatewayImplementation: kgatewayName,
+				providers:             []string{ingressnginx.Name},


Yes, I'm lookin into it. I assume you mean in general rather than as feedback on this specific PR @Stevenjin8.

Signed-off-by: omar <omar.hammami@solo.io>

johananl · 2026-02-17T16:15:46Z

Thanks for following up. I think we're good. We do have a lot of inconsistencies on doc comment style but I'm wondering if we shouldn't just use a linter to enforce this (I know many people don't care about this too much).

johananl · 2026-02-17T16:23:01Z

/lgtm

johananl · 2026-02-17T16:24:24Z

Thank you for your contribution @puertomontt.

puertomontt · 2026-02-17T16:43:56Z

Thanks for the reivew @johananl @Stevenjin8

* kgateway emitter Signed-off-by: omar <omar.hammami@solo.io> * remove test and fix year Signed-off-by: omar <omar.hammami@solo.io> * add puertomontt as owner Signed-off-by: omar <omar.hammami@solo.io> * remove from owners Signed-off-by: omar <omar.hammami@solo.io> * e2e test Signed-off-by: omar <omar.hammami@solo.io> * address feedback Signed-off-by: omar <omar.hammami@solo.io> * add emitter to testCase Signed-off-by: omar <omar.hammami@solo.io> * update test Signed-off-by: omar <omar.hammami@solo.io> * remove periods Signed-off-by: omar <omar.hammami@solo.io> * remove unused code Signed-off-by: omar <omar.hammami@solo.io> * go mod changes Signed-off-by: omar <omar.hammami@solo.io> --------- Signed-off-by: omar <omar.hammami@solo.io>

k8s-ci-robot requested review from LiorLieberman and Stevenjin8 January 26, 2026 15:34

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2026

puertomontt changed the title ~~kgateway emitter~~ feat: kgateway emitter Jan 26, 2026

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 26, 2026

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2026

Stevenjin8 reviewed Jan 28, 2026

View reviewed changes

Comment thread pkg/i2gw/emitters/kgateway/buffer.go Outdated

Stevenjin8 reviewed Jan 28, 2026

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2026

puertomontt requested review from robscott and youngnick as code owners February 8, 2026 03:56

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 8, 2026

k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 9, 2026

danehans mentioned this pull request Feb 9, 2026

Migrate Agentgateway Emitter Features Upstream kgateway-dev/ingress2gateway#86

Open

k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 10, 2026

puertomontt mentioned this pull request Feb 10, 2026

REQUEST: New membership for puertomontt kubernetes/org#6127

Closed

11 tasks

puertomontt force-pushed the kgw-emit branch from a39deda to 3268c59 Compare February 12, 2026 19:05

johananl reviewed Feb 17, 2026

View reviewed changes

puertomontt added 10 commits February 17, 2026 09:07

kgateway emitter

67c8dd7

Signed-off-by: omar <omar.hammami@solo.io>

remove test and fix year

746dd85

Signed-off-by: omar <omar.hammami@solo.io>

add puertomontt as owner

3e53690

Signed-off-by: omar <omar.hammami@solo.io>

remove from owners

3f7b033

Signed-off-by: omar <omar.hammami@solo.io>

e2e test

c2aaa22

Signed-off-by: omar <omar.hammami@solo.io>

address feedback

11ce3e9

Signed-off-by: omar <omar.hammami@solo.io>

add emitter to testCase

6dffa2c

Signed-off-by: omar <omar.hammami@solo.io>

update test

84898e8

Signed-off-by: omar <omar.hammami@solo.io>

remove periods

7f93ebe

Signed-off-by: omar <omar.hammami@solo.io>

remove unused code

12059e9

Signed-off-by: omar <omar.hammami@solo.io>

puertomontt force-pushed the kgw-emit branch 2 times, most recently from 7bb3fea to 43d3bdd Compare February 17, 2026 15:22

go mod changes

18a1147

Signed-off-by: omar <omar.hammami@solo.io>

puertomontt force-pushed the kgw-emit branch from 43d3bdd to 18a1147 Compare February 17, 2026 15:33

k8s-ci-robot assigned johananl Feb 17, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026

k8s-ci-robot merged commit e47837b into kubernetes-sigs:main Feb 17, 2026
4 checks passed

puertomontt deleted the kgw-emit branch March 5, 2026 16:15

Conversation

puertomontt commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 26, 2026

Uh oh!

Stevenjin8 commented Jan 28, 2026

Uh oh!

Uh oh!

Stevenjin8 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Stevenjin8 commented Jan 28, 2026

Uh oh!

Stevenjin8 commented Feb 8, 2026

Uh oh!

Stevenjin8 commented Feb 8, 2026

Uh oh!

puertomontt commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puertomontt commented Feb 10, 2026

Uh oh!

Stevenjin8 commented Feb 10, 2026

Uh oh!

puertomontt commented Feb 10, 2026

Uh oh!

johananl commented Feb 16, 2026

Uh oh!

puertomontt commented Feb 16, 2026

Uh oh!

Stevenjin8 commented Feb 16, 2026

Uh oh!

johananl commented Feb 17, 2026

Uh oh!

johananl commented Feb 17, 2026

Uh oh!

johananl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

johananl Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johananl commented Feb 17, 2026

Uh oh!

johananl commented Feb 17, 2026

Uh oh!

Uh oh!

johananl commented Feb 17, 2026

Uh oh!

puertomontt commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

puertomontt commented Jan 26, 2026 •

edited

Loading

puertomontt commented Feb 9, 2026 •

edited

Loading