feat: buffer annotations and envoy gateway emitter by kkk777-7 · Pull Request #305 · kubernetes-sigs/ingress2gateway

kkk777-7 · 2026-01-18T16:21:20Z

What type of PR is this?

/kind feature

~~depends on #298~~

What this PR does / why we need it:
Add Envoy Gateway emitter.
Support proxy body size annotations.

nginx.ingress.kubernetes.io/proxy-body-size
nginx.ingress.kubernetes.io/client-body-buffer-size

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Support for ingress nginx body size annotations (proxy-body-size, client-body-buffer-size). and Add Envoy Gateway emitter.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot · 2026-01-18T16:21:29Z

Hi @kkk777-7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

Stevenjin8

Yeah this is pretty much exactly what I imagined. Do you mind adding a CODEOWNERS file and adding yourself as a codeowner for the envoy gateway emitter? And say that you agree to https://github.com/kubernetes-sigs/ingress2gateway/blob/main/docs/emitters.md

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 · 2026-01-22T01:30:42Z

@Stevenjin8
I added CODEOWNERS. and agree to Governance :)

Stevenjin8

Very minor comments

Stevenjin8 · 2026-01-22T19:09:06Z

/ok-to-test

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 · 2026-01-24T07:52:29Z

Envoy Gateway’s latest version requires Go 1.25.3. But, golangci-lint v1 doesn’t support Go 1.25.
If we can migrate to golangci-lint v2, I’ll handle that in a separate PR.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

Stevenjin8 · 2026-01-28T20:26:25Z

@kkk777-7 tests are failing
/approve

kkk777-7 · 2026-01-29T16:23:31Z

Hi @Stevenjin8, golangci-lint v1 doesn't support Go v1.25. so happened CI failure.
I opened separate PR for migrating golangci-lint v2. #323

I’d appreciate it if we could merge #323 first, and then merge this one afterward.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 · 2026-01-31T06:28:17Z

/retest

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

Stevenjin8 · 2026-02-04T16:19:48Z

/approve cancel
/lgtm

k8s-ci-robot · 2026-02-04T16:19:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkk777-7, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Stevenjin8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Stevenjin8 · 2026-02-04T16:20:07Z

/retest

* feat: support route rule name Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * feat: body size parse in ingress nginx provider Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * feat: body size emission in envoy gateway provider Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add notifications Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * update byte regex Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add CODEOWNERS Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * address comments in provider Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * address comments in emitter Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: setting nil in IR Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix boilerplate lint Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 added 4 commits January 9, 2026 14:44

feat: support route rule name

fca3448

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

Merge branch 'main' into support-route-rule-name

7bb7268

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

feat: body size parse in ingress nginx provider

99a7a6d

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

feat: body size emission in envoy gateway provider

ebea117

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 18, 2026

k8s-ci-robot requested review from LiorLieberman and Stevenjin8 January 18, 2026 16:21

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2026

kkk777-7 added 2 commits January 19, 2026 16:06

add notifications

9c39be0

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

update byte regex

8332e90

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 commented Jan 19, 2026

View reviewed changes

Comment thread pkg/i2gw/emitters/envoygateway/emitter.go

puertomontt reviewed Jan 19, 2026

View reviewed changes

Comment thread pkg/i2gw/emitter_intermediate/intermediate_representation.go

Stevenjin8 reviewed Jan 21, 2026

View reviewed changes

Stevenjin8 mentioned this pull request Jan 21, 2026

feat: Implement standard CORS support #303

Merged

add CODEOWNERS

729be84

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 temporarily deployed to release January 22, 2026 18:18 — with GitHub Actions Inactive

Stevenjin8 reviewed Jan 22, 2026

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/bodysize.go Outdated

Stevenjin8 reviewed Jan 22, 2026

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/bodysize.go Outdated

Stevenjin8 reviewed Jan 22, 2026

View reviewed changes

Comment thread pkg/i2gw/emitters/envoygateway/buffer.go

Stevenjin8 requested changes Jan 22, 2026

View reviewed changes

kkk777-7 added 2 commits January 23, 2026 13:31

Merge branch 'main' into feat-buffer-annotations

9c7fb01

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

address comments in provider

b1fd450

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

address comments in emitter

3f88b59

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026

fix: setting nil in IR

54b1ab4

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

puertomontt mentioned this pull request Jan 26, 2026

feat: kgateway emitter #320

Merged

kkk777-7 mentioned this pull request Jan 28, 2026

REQUEST: New membership for kkk777-7 kubernetes/org#6104

Closed

11 tasks

kkk777-7 temporarily deployed to release January 28, 2026 20:26 — with GitHub Actions Inactive

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026

kkk777-7 mentioned this pull request Jan 29, 2026

Migrate golangci lint v2 #323

Merged

Merge branch 'main' into feat-buffer-annotations

eaba140

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

fix boilerplate lint

c1c59a9

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2026

Merge branch 'main' into feat-buffer-annotations

0f69003

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2026

k8s-ci-robot assigned Stevenjin8 Feb 4, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2026

k8s-ci-robot merged commit bd0fbb5 into kubernetes-sigs:main Feb 4, 2026
4 checks passed

puertomontt mentioned this pull request Feb 10, 2026

REQUEST: New membership for puertomontt kubernetes/org#6127

Closed

11 tasks

Conversation

kkk777-7 commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 18, 2026

Uh oh!

Uh oh!

Uh oh!

Stevenjin8 left a comment

Choose a reason for hiding this comment

Uh oh!

kkk777-7 commented Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stevenjin8 left a comment

Choose a reason for hiding this comment

Uh oh!

Stevenjin8 commented Jan 22, 2026

Uh oh!

kkk777-7 commented Jan 24, 2026

Uh oh!

Stevenjin8 commented Jan 28, 2026

Uh oh!

kkk777-7 commented Jan 29, 2026

Uh oh!

kkk777-7 commented Jan 31, 2026

Uh oh!

Stevenjin8 commented Feb 4, 2026

Uh oh!

k8s-ci-robot commented Feb 4, 2026

Uh oh!

Stevenjin8 commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kkk777-7 commented Jan 18, 2026 •

edited

Loading