Migrate golangci lint v2#323
Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @kkk777-7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/L
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
| allow-parallel-runners: false | ||
|
|
||
| linters: | ||
| fast: false |
There was a problem hiding this comment.
linters.fast removed.
https://golangci-lint.run/docs/product/migration-guide/#lintersfast
| - govet | ||
| - misspell | ||
| disable-all: false | ||
| presets: |
There was a problem hiding this comment.
linters.presets removed.
https://golangci-lint.run/docs/product/migration-guide/#linterspresets
migrate: individual linters to linters.enable
| - linters: | ||
| - staticcheck | ||
| text: "ST1005:" | ||
| # Allow embedded field, currently this style is used in many places |
There was a problem hiding this comment.
If we should fix this style, I'll fix in this PR.
| timeout: 10m | ||
| issues-exit-code: 1 | ||
| tests: true | ||
| exclude-dirs-use-default: true |
There was a problem hiding this comment.
exclude-dirs-use-default replaces
linters:
exclusions:
paths:
- third_party$
- builtin$
- examples$https://golangci-lint.run/docs/product/migration-guide/#issuesexclude-dirs-use-default
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kkk777-7, Stevenjin8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Got @rikatz blessing on Slack, so also going to /lgtm on his behalf /lgtm |
k8s-ci-robot
added
the
lgtm
|
sorry I should have given lgtm, but lgtm! thanks @Stevenjin8 :D |
* migrate golangci-lint v2 Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: gosec lint Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: govet lint Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: testifylint Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: staticcheck Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * update go version in workflow Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * revert timeout Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
4 participants
What this PR does / why we need it:
Migrate golangci-lint v2.
#305 supports Envoy Gateway Emitter.
Envoy Gateway’s latest version requires Go 1.25.3. But, golangci-lint v1 doesn’t support Go 1.25.
This causes CI failure.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: