Skip to content

Move symbol support subfeatures into constructor/methods #26509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 14, 2025

Summary

Moves the Non-registered symbol as target subfeatures:

  • from WeakRef to the constructor (WeakRef.WeakRef)
  • from FinalizationRegistry to the methods (FinalizationRegistry.{register,unregister})

Also adds the Firefox impl_url.

Test results and supporting details

Related issues

Fixes #26132.

@caugner caugner requested a review from Elchi3 April 14, 2025 14:52
@github-actions github-actions bot added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:l [PR only] 101-1000 LoC changed labels Apr 14, 2025
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit c670def into main Apr 15, 2025
10 checks passed
@Elchi3 Elchi3 deleted the 26132-move-symbol-as-target branch April 15, 2025 10:53
@mdn-bot mdn-bot mentioned this pull request Apr 15, 2025
@Mahya321123
Copy link

Very good thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

javascript.builtins.FinalizationRegistry.register - Symbols are not supported in Firefox
3 participants