Skip to content

Fix KTX2 loader delegation to top-level default loader #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Apr 16, 2024

If the user has amended the default loader, we should respect that when loading textures. Ditto for DRACO mesh geometry.

Twin PR: RobotLocomotion/drake#21313


This change is Reviewable

If the user has amended the default loader, we should respect that
when loading textures. Ditto for DRACO mesh geometry.
Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, all discussions resolved

@jwnimmer-tri
Copy link
Contributor Author

+@SeanCurtis-TRI for feature review, please.

+@ggould-tri for platform review per schedule, please.

Copy link

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, with my limited understanding of javascript.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SeanCurtis-TRI)

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SeanCurtis-TRI)

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit 601b55d into meshcat-dev:master Apr 16, 2024
@jwnimmer-tri jwnimmer-tri deleted the ktx2-static-html branch April 16, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants