-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[workspace] Upgrade meshcat to latest commit #21313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Upgrade meshcat to latest commit #21313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least one assigned reviewer, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
tools/workspace/meshcat/repository.bzl
line 13 at r1 (raw file):
drake/tools/workspace/meshcat/README.md for details. """, commit = "c0cff8e6990db8e9fb968e6309f9ca16c9dbd3b1",
Working
Needs sha from master
+@SeanCurtis-TRI for both reviews (and meshcat manual test testing), please. |
7f9c0a2
to
276fd0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform)
tools/workspace/meshcat/repository.bzl
line 13 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
Needs sha from master
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
Twin PR: meshcat-dev/meshcat#179
Closes: #21314.
This change is