[FancyZones Editor] Logger #13928
Merged
[FancyZones Editor] Logger #13928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
stefansjfw
reviewed
Oct 21, 2021
|
|
||
| var methodName = stackTrace.GetFrame(3)?.GetMethod(); | ||
| var className = methodName?.DeclaringType.Name; | ||
| return className + " :: " + methodName?.Name; |
Contributor
There was a problem hiding this comment.
nit: "::" instead of " :: ".
[16:51:56.7245037] [Info] LayoutPreview::OnLoaded
looks better than
[16:51:56.7245037] [Info] LayoutPreview :: OnLoaded
IMHO
Contributor
There was a problem hiding this comment.
Also, when searching logs, I would expect no space there
stefansjfw
reviewed
Oct 21, 2021
| _eventHandle = new EventWaitHandle(false, EventResetMode.AutoReset, interop.Constants.FZEExitEvent()); | ||
| if (_eventHandle.WaitOne()) | ||
| { | ||
| Logger.LogInfo("FancyZones disabled, exit"); |
Contributor
There was a problem hiding this comment.
is this correct? I believe FZ is not disabled here? -> e.g "FanzyZones Editor exit event processed"
stefansjfw
approved these changes
Oct 21, 2021
Contributor
stefansjfw
left a comment
stefansjfw
left a comment
There was a problem hiding this comment.
Looks good! This should help us a lot with reproducing bugs! Let's not forget to add more logging when we change/add some code or see that log could be useful at some place
jaimecbernardo
approved these changes
Oct 22, 2021
Contributor
jaimecbernardo
left a comment
jaimecbernardo
left a comment
There was a problem hiding this comment.
Rubberstamp LGTM!
Using logger instead of manually is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Added logger to the FZ Editor.
It also could help with issues such as #13105 to analyze repro steps.
What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.