[FancyZones Editor] Crash fix #13930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
approved these changes
Oct 21, 2021
Contributor
|
/azp run Build failed initially |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaimecbernardo
approved these changes
Oct 22, 2021
Contributor
jaimecbernardo
left a comment
jaimecbernardo
left a comment
There was a problem hiding this comment.
Waiting for things to finish before exiting.
Rubberstamp LGTM!
capturing local variables in anonymous methods could cause memory leaks
SeraphimaZykova
force-pushed
the
13105-fancyzones-editor-crash
branch
from
6baae04 to
f186ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
The crash always happens at
System.AppContext.OnProcessExit(). It could be caused by not properly closing windows or disposing of controls.In case of a crash happens on the editor start, there could be another reason for closing the editor, such as incorrect settings, and after closing, the crash happened. We only have the last error message saved. So for this type of problem logger could help to investigate.
What is include in the PR:
Disposeof App.How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.