Skip to content

Projects with a nested Windows namespace (e.g., Microsoft::Windows) fail to compile #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

Scottj1s
Copy link
Member

@Scottj1s Scottj1s commented Nov 4, 2022

Discovered with WinUI-PR pipeline run: update versions for CppWinRT, wil, BuildTools, .NET runtime

@Scottj1s
Copy link
Member Author

Scottj1s commented Nov 4, 2022

Fixes build errors:

...\winrt\Microsoft.UI.Xaml.Markup.h(1278,53): Error C3083: 'Foundation': the symbol to the left of a '::' must be a type
...\winrt\Microsoft.UI.Xaml.Markup.h(1278,65): Error C2039: 'IInspectable': is not a member of 'winrt::Microsoft::Windows'
...\winrt\Microsoft.UI.Xaml.Markup.h(1291,65): Error C3083: 'Foundation': the symbol to the left of a '::' must be a type
...\winrt\Microsoft.UI.Xaml.Markup.h(1291,77): Error C2039: 'IInspectable': is not a member of 'winrt::Microsoft::Windows'

@sylveon
Copy link
Contributor

sylveon commented Nov 4, 2022

Would you mind adding the fix for microsoft/WindowsAppSDK#1901 as well while we're on the topic of nested Windows namespaces?

@sylveon
Copy link
Contributor

sylveon commented Nov 4, 2022

Also, maybe a unit test for this scenario would be desirable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants