Skip to content

Projects with a nested Windows namespace (e.g., Microsoft::Windows) fail to compile #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions strings/base_xaml_component_connector.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ WINRT_EXPORT namespace winrt::Windows::UI::Xaml::Markup
D::InitializeComponent();
}

void Connect(int32_t connectionId, Windows::Foundation::IInspectable const& target)
void Connect(int32_t connectionId, winrt::Windows::Foundation::IInspectable const& target)
{
if constexpr (m_has_connectable_base)
{
Expand All @@ -30,7 +30,7 @@ WINRT_EXPORT namespace winrt::Windows::UI::Xaml::Markup
D::Connect(connectionId, target);
}

auto GetBindingConnector(int32_t connectionId, Windows::Foundation::IInspectable const& target)
auto GetBindingConnector(int32_t connectionId, winrt::Windows::Foundation::IInspectable const& target)
{
if constexpr (m_has_connectable_base)
{
Expand Down