Skip to content

Support ${vscodeInstallPath} or similar in environment variable collection #115053

Closed
@Tyriar

Description

@Tyriar

As a means to workaround the install directory changing frequently in insiders, js-debug its bootloader into workspace storage. This falls apart when rebuilding containers though as js-debug expects the file to be there but it's not, and it cannot fix the problem because the extension has not activated yet. More context: microsoft/vscode-remote-release#4308

The solutions is to allow task variables to be resolved in environment variable collection (I don't think they are currently), and then support a new one which allows the usage of VS Code's install path. This way the path to the actual bootloader would remain static under the extension's directory and does not need to be installed. The variable ${vscodeInstallPath} would be resolved on terminal creation, for example:

collection.append('PATH', '${vscodeInstallPath}/extensions/git/bin');
collection.replace('USED_BY_GIT', '${vscodeInstallPath}/extensions/git/bin/auth.sh');
collection.replace('NODE_OPTIONS', 'require("${vscodeInstallPath}/ms-vscode.js-debug/bootloader.js")')

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsidersterminalGeneral terminal issues that don't fall under another labelverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions