Skip to content

Support vscode install directory variable and resolve in env var collection variables #115758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2021
Merged

Support vscode install directory variable and resolve in env var collection variables #115758

merged 4 commits into from
Feb 5, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 4, 2021

Fixes #115053

@Tyriar Tyriar added this to the February 2021 milestone Feb 4, 2021
@Tyriar Tyriar self-assigned this Feb 4, 2021
@Tyriar Tyriar changed the title Support vscode/extension install directory and resolve env var collection variables Support vscode install directory variable and resolve in env var collection variables Feb 4, 2021
@Tyriar Tyriar requested a review from alexr00 February 4, 2021 15:42
@Tyriar Tyriar marked this pull request as ready for review February 4, 2021 15:42
@Tyriar
Copy link
Member Author

Tyriar commented Feb 4, 2021

@alexr00 I ended up landing on appFolder to align with workspaceFolder, and I don't think we actually need the extension path for now, plus there are some complications getting that in the ext host/remote.

alexr00
alexr00 reviewed Feb 4, 2021
View reviewed changes
@Tyriar Tyriar merged commit 80a738c into master Feb 5, 2021
@Tyriar Tyriar deleted the tyriar/115053 branch February 5, 2021 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 left review comments

Assignees

@Tyriar Tyriar

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
February 2021
Development

Successfully merging this pull request may close these issues.

Support ${vscodeInstallPath} or similar in environment variable collection
2 participants
@Tyriar @alexr00