[infra] Do not wait for dedupe check before running other CI jobs
#1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Janpot
reviewed
May 7, 2025
| @@ -180,6 +156,19 @@ jobs: | |||
| - checkout | |||
| - install_js: | |||
| react-version: << parameters.react-version >> | |||
| - run: | |||
There was a problem hiding this comment.
find this step rather questionable so I'm not against removing it as well
There was a problem hiding this comment.
Good point. If by any chance (although I can't think of any) some files are unstaged at this point, they will be picked up by line 177.
Janpot
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting mui/mui-x#17729 (including mui/mui-x#17729 (comment)).