[code-infra] Remove required checkout step

[JCQuintas]

Remove requires: - checkout for CircleCI steps.

Since mui/material-ui#40670, we no longer rely on the checkout step to cache the npm dependencies installation, it turns out that it's faster to start from scratch. So this checkout step doesn't speed up the CI, and only blocks running the cases, we forget to dedupe the installs. So it's slower. This should trim ~2 minutes from the overall wait time for the tests to run, since all tests wait for this to finish.

[mui-bot]

Deploy preview: https://deploy-preview-17729--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e785076

[oliviertassinari]

It doesn't speed up the tests, and only blocks running the cases we forget to dedupe the installs.

Oh, because of mui/material-ui#40670. Is this still true with the latest pnpm version? If yes, then all the repositories we have do this wrong and should be updated. A great way to make the CI at least 60s faster for everyone in the org.

[LukasTy]

Oh, because of mui/material-ui#40670. Is this still true? If yes, then all the repositories we have do this wrong and should be patched 😆

Yes, we still don't cache the pnpm store on CircleCI.
Are you suggesting bringing back the caching? Or just confirming to move forward with this change for all repos? 🤔

[oliviertassinari]

Are you suggesting bringing back the caching?

I wonder if it's still an up-to-date decision. But yeah, ok, it seems like it, e.g. vercel/next.js#75600 no pnpm caching either for Next.js.

[Janpot]

very nice 👌

[Janpot]

I guess the difference will be that now the dedupe check doesn't block running the rest of the tests anymore. perhaps we should just fold this check into the test_static job?

Porting to core: mui/material-ui#46099.

[JCQuintas]

I guess the difference will be that now the dedupe check doesn't block running the rest of the tests anymore. perhaps we should just fold this check into the test_static job?

I think it would make sense

[michaldudak]

Porting to Base UI: mui/base-ui#1883