Skip to content

[charts] Export useFunnelSeries and useRadarSeries #18034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

[charts] Export useFunnelSeries and useRadarSeries #18034

merged 2 commits into from
May 28, 2025

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented May 27, 2025 •
edited
Loading

Exporting the hooks that were missing

@JCQuintas JCQuintas self-assigned this May 27, 2025
@JCQuintas JCQuintas added type: new feature Introduces a new piece of functionality or capability. plan: Pro Impact at least one Pro user scope: charts Changes or issues related to the charts product labels May 27, 2025
@mui-bot
Copy link

mui-bot commented May 27, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18034--material-ui-x.netlify.app/

Bundle size report

Total Size Change:${\tiny{\color{red}▲}}$+299B(0.00%) - Total Gzip Change:${\tiny{\color{red}▲}}$+74B(0.00%)
Files: 118 total (0 added, 0 removed, 2 changed)

Show 2 more bundle changes

@mui/x-charts-pro parsed:${\tiny{\color{red}▲}}$+219B(+0.07%) gzip:${\tiny{\color{red}▲}}$+65B(+0.06%)
@mui/x-charts parsed:${\tiny{\color{red}▲}}$+80B(+0.03%) gzip:${\tiny{\color{red}▲}}$+9B(+0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against a1e843e

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #18034 will not alter performance

Comparing JCQuintas:export-use-funnel-series (c6153fb) with master (37af530)

Summary

✅ 9 untouched benchmarks

@JCQuintas JCQuintas mentioned this pull request May 27, 2025
Closed
bernardobelchior
bernardobelchior reviewed May 28, 2025
View reviewed changes
scripts/x-charts-pro.exports.json
Comment on lines +433 to +434
{ "name": "useFunnelSeries", "kind": "Function" },
{ "name": "useFunnelSeriesContext", "kind": "Function" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to export both useFunnelSeries and useFunnelSeriesContext?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do that for all other series

Copy link
Member

@bernardobelchior bernardobelchior May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I was asking because it might be confusing as the difference might not be clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about it before, but decided to release all for consistency.

@JCQuintas JCQuintas merged commit 9a3ea7f into mui:master May 28, 2025
24 checks passed
@JCQuintas JCQuintas deleted the export-use-funnel-series branch May 28, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardobelchior bernardobelchior bernardobelchior left review comments

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels
plan: Pro Impact at least one Pro user scope: charts Changes or issues related to the charts product type: new feature Introduces a new piece of functionality or capability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCQuintas @mui-bot @bernardobelchior @alexfauquette