Skip to content

[charts] Export useFunnelSeries and useRadarSeries #18034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

[charts] Export useFunnelSeries and useRadarSeries #18034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6153fb
[charts] Export `useFunnelSeries` and `useRadarSeries`
JCQuintas May 27, 2025
a1e843e
Merge branch 'master' into export-use-funnel-series
JCQuintas May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/x-charts-pro/src/hooks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
export { useHeatmapSeries } from './useHeatmapSeries';
export * from './useHeatmapSeries';
export * from './useFunnelSeries';
export * from './zoom';
1 change: 1 addition & 0 deletions packages/x-charts/src/hooks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export * from './useScatterSeries';
export * from './usePieSeries';
export * from './useBarSeries';
export * from './useLineSeries';
export * from './useRadarSeries';
export * from './useItemHighlighted';
export * from './useItemHighlightedGetter';
export * from './useLegend';
Expand Down
11 changes: 11 additions & 0 deletions scripts/x-charts-pro.exports.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,15 @@
{ "name": "useChartRootRef", "kind": "Function" },
{ "name": "useChartsLocalization", "kind": "Variable" },
{ "name": "useDrawingArea", "kind": "Function" },
{ "name": "useFunnelSeries", "kind": "Function" },
{ "name": "useFunnelSeriesContext", "kind": "Function" },
Comment on lines +433 to +434
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to export both useFunnelSeries and useFunnelSeriesContext?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do that for all other series

Copy link
Member

@bernardobelchior bernardobelchior May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I was asking because it might be confusing as the difference might not be clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about it before, but decided to release all for consistency.

{ "name": "UseFunnelSeriesContextReturnValue", "kind": "TypeAlias" },
{ "name": "UseFunnelSeriesReturnValue", "kind": "TypeAlias" },
{ "name": "useGaugeState", "kind": "Function" },
{ "name": "useHeatmapSeries", "kind": "Function" },
{ "name": "useHeatmapSeriesContext", "kind": "Function" },
{ "name": "UseHeatmapSeriesContextReturnValue", "kind": "TypeAlias" },
{ "name": "UseHeatmapSeriesReturnValue", "kind": "TypeAlias" },
{ "name": "useIsZoomInteracting", "kind": "Function" },
{ "name": "useItemHighlighted", "kind": "Function" },
{ "name": "useItemHighlightedGetter", "kind": "Function" },
Expand All @@ -449,6 +456,10 @@
{ "name": "UsePieSeriesReturnValue", "kind": "TypeAlias" },
{ "name": "useRadarItemTooltip", "kind": "Variable" },
{ "name": "UseRadarItemTooltipReturnValue", "kind": "TypeAlias" },
{ "name": "useRadarSeries", "kind": "Function" },
{ "name": "useRadarSeriesContext", "kind": "Function" },
{ "name": "UseRadarSeriesContextReturnValue", "kind": "TypeAlias" },
{ "name": "UseRadarSeriesReturnValue", "kind": "TypeAlias" },
{ "name": "useRadiusAxes", "kind": "Function" },
{ "name": "useRadiusAxis", "kind": "Function" },
{ "name": "useRadiusScale", "kind": "Function" },
Expand Down
4 changes: 4 additions & 0 deletions scripts/x-charts.exports.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,10 @@
{ "name": "UsePieSeriesReturnValue", "kind": "TypeAlias" },
{ "name": "useRadarItemTooltip", "kind": "Variable" },
{ "name": "UseRadarItemTooltipReturnValue", "kind": "TypeAlias" },
{ "name": "useRadarSeries", "kind": "Function" },
{ "name": "useRadarSeriesContext", "kind": "Function" },
{ "name": "UseRadarSeriesContextReturnValue", "kind": "TypeAlias" },
{ "name": "UseRadarSeriesReturnValue", "kind": "TypeAlias" },
{ "name": "useRadiusAxes", "kind": "Function" },
{ "name": "useRadiusAxis", "kind": "Function" },
{ "name": "useRadiusScale", "kind": "Function" },
Expand Down