[DO NOT MERGE] Test pandas 1.4 release candidate

[jorisvandenbossche]

Similarly as #2608, not to merge, but just to test the pandas release candidate on your CI.

[codecov]

Codecov Report

Merging #2727 (363bdd8) into master (77e3b6b) will decrease coverage by 5.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2727      +/-   ##
==========================================
- Coverage   97.53%   91.64%   -5.89%     
==========================================
  Files          17       17              
  Lines        6439     6439              
==========================================
- Hits         6280     5901     -379     
- Misses        159      538     +379     

Impacted Files	Coverage Δ
seaborn/matrix.py	42.41% <0.00%> (-53.43%)	⬇️
seaborn/algorithms.py	87.50% <0.00%> (-12.50%)	⬇️
seaborn/_docstrings.py	87.50% <0.00%> (-12.50%)	⬇️
seaborn/regression.py	86.10% <0.00%> (-11.79%)	⬇️
seaborn/_statistics.py	96.55% <0.00%> (-3.45%)	⬇️
seaborn/utils.py	92.81% <0.00%> (-2.40%)	⬇️
seaborn/_core.py	97.92% <0.00%> (-0.56%)	⬇️
seaborn/distributions.py	96.07% <0.00%> (-0.33%)	⬇️
seaborn/axisgrid.py	95.78% <0.00%> (-0.29%)	⬇️
seaborn/categorical.py	98.31% <0.00%> (-0.22%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e3b6b...363bdd8. Read the comment docs.

[jorisvandenbossche]

So there is one failure:

______________________ TestClustermap.test_corr_df_input _______________________
[gw1] linux -- Python 3.8.12 /opt/hostedtoolcache/Python/3.8.12/x64/bin/python

self = <seaborn.tests.test_matrix.TestClustermap object at 0x7f5087e910d0>

    def test_corr_df_input(self):
        df = self.df_norm.corr()
        cg = mat.ClusterGrid(df, **self.default_kws)
        cg.plot(**self.default_plot_kws)
        diag = cg.data2d.values[np.diag_indices_from(cg.data2d)]
>       npt.assert_array_equal(diag, np.ones(cg.data2d.shape[0]))
E       AssertionError: 
E       Arrays are not equal
E       
E       Mismatched elements: 5 / 8 (62.5%)
E       Max absolute difference: 6.66133815e-16
E       Max relative difference: 6.66133815e-16
E        x: array([1., 1., 1., 1., 1., 1., 1., 1.])
E        y: array([1., 1., 1., 1., 1., 1., 1., 1.])

seaborn/tests/test_matrix.py:767: AssertionError

Might be an inexact floating point issue?

[mwaskom]

Yeah that sounds right. I wonder why that passed before. Did the underlying correlation algorithm change?

[mwaskom]

#2728

[mwaskom]

I also have no idea what the test is meant to be covering 🙃

[mwaskom]

BTW if you want to put in some tiny cosmetic change so that I don't need to approve CI to run on your PRs, happy to quickly accept that. (I don't think you can allowlist specific accounts?)

[jorisvandenbossche]

Did the underlying correlation algorithm change?

Not directly an idea.

BTW if you want to put in some tiny cosmetic change so that I don't need to approve CI to run on your PRs, happy to quickly accept that. (I don't think you can allowlist specific accounts?)

Yeah, I was thinking that same that that would be useful :)

[mwaskom]

Congrats on the release!